Set up CI with Azure Pipelines #655

lupine86 · 2018-11-20T21:38:35Z

PR checklist

Addresses an existing issue: fixes Request: Build, Test and Release tslint-microsoft-contrib using Azure Pipelines #656
New feature, bugfix, or enhancement
- Includes tests
Documentation update

Overview of change:

Add support for CI using Azure Pipelines

Is there anything you'd like reviewers to focus on?

I have created a new organization and project on Azure Devops to support the tslint-microsoft-contrib project here: https://dev.azure.com/tslint-microsoft-contrib/
I invited Joshua Goldberg and Hamlet D'Arcy and made them collection level admins.

IllusionMH · 2018-11-20T23:01:21Z

Is it possible to setup more node version and probably Windows builds too?

Looks a bit strange to test only against Node 8 while Node 10 is latest LTS.

JoshuaKGoldberg · 2018-11-21T04:22:02Z

Hi @lupine86, thanks for sending this in! Normally we track suggested changes in issues before accepting PRs; is there a particular reason you want this in?

IllusionMH · 2018-11-21T05:22:06Z

Also worth to add: there are new npm tasks that should generate report from Mocha. However #489 will migrate almost all test away from Mocha, and only test for few utils and deprecated formatters will left as mocha tests. I do not think that it worth it to have report just for them.

lupine86 · 2018-11-26T13:16:44Z

Add #656 to track community discussion.

JoshuaKGoldberg · 2018-11-26T19:10:31Z

Per #656: anything we switch to would need to have feature parity with what we have now in OS and Node versions.

Per #489: tslint-microsoft-contrib is going to get rid of its older rule tests and fully switch to TSLint core's. We can save some work by finishing that work first.

JoshuaKGoldberg

I put some comments here and in #656

* Validate order of rules in README.md (fixes microsoft#816) * Fix rules order in README.md * create-rule task also updates README (fixed microsoft#816) * Update CONTRIBUTING.md with detais about README.md actions (fixes microsoft#648)

* Replace Release Notes with info about CHANGELOG.md and Releases * Replace Release Notes with links to CHANGELOG.md and Releases * Updated Releases (markdown) * Revert "Updated Releases (markdown)" This reverts commit b9214fd89cc3cd2238a4f43c3c4bf7ac3c2cc7e9. * Add instruction to replace @next placeholder * Move Wiki files to docs folder (fixes microsoft#808) * Apply Prettier formatter to docs * Update link to Releases doc * Replace Markdown table format with HTML table * Add links from removed Releases page to README.md

) * ported react-unused-props-and-state tests to new test framework * removed react-unused-props-and-state tests from old framework

…icrosoft#809) * Revamped configs into 'core', 'latest', and (legacy) 'recommended' Those three config files now exist as `.json` under `/configs`; they're copied to `dist/build/configs`. `recommended.json` becomes `tslint.json` as well. * Normalized trailing commas; added back .gitignore fields * Moved void-zero to latest.json * Moved to exporting root-level configs * Switched to auto-generating latest.json * Aligned naming with TSLint's recommended -> latest * Update ExtendedMetadata.ts :qa! rebasing :wq :qa!

…mponents (microsoft#824) * added suite of tests to cover function components * traverse found arrow functions, function declarations and expressions * add helper functions to extract type information * wireup logic to traverse arrow functions and function components * reorganized tests to help with understanding coverage * check shorthand types for React function components * update comment

…-contrib

Old code; will take another look

JoshuaKGoldberg

Thanks for sending this in! A few things to touch up, but it looks like it's on its way.

.azure-pipelines-steps.yml

README.md

azure-pipelines.yml

JoshuaKGoldberg · 2019-03-02T16:10:45Z

package.json

@@ -89,7 +91,8 @@
    "lint-staged": "^8.0.4",
    "mkdirp": "^0.5.1",
    "mocha": "5.2.0",
-    "npm-run-all": "^4.1.5",
+    "mocha-junit-reporter": "^1.18.0",
+    "npm-run-all": "^4.1.3",


Looks like a merge hiccup: npm-run-all in this repo is now up to 4.1.5, not 4.1.3.

JoshuaKGoldberg · 2019-03-02T16:12:02Z

package.json

@@ -62,9 +62,11 @@
    "lint:tests": "tslint -p tsconfig.json -t stylish -c src/tests/tslint.json -e src/tests/references.ts \"src/tests/**/*.ts\"",
    "prettier": "prettier --write \"**/*.{js,ts,tsx,json,md}\"",
    "start": "npm-run-all clean copy:json watch:src",
-    "test:mocha": "mocha \"dist/src/tests/**/*.js\" --timeout 5000",
+    "test:mocha": "mocha \"dist/src/tests/**/*.js\" --timeout 5000 --reporter mocha-junit-reporter",


I think you'll want to take another look at the changes to these tasks. Seems like test:mocha changes should be reverted, as test-junit reports with the junit reporter?

package.json

JoshuaKGoldberg · 2019-03-02T16:19:37Z

azure-pipelines.yml

+# Node.js
+# Build a general Node.js project with npm.
+# Add steps that analyze code, save build artifacts, deploy, and more:
+# https://docs.microsoft.com/azure/devops/pipelines/languages/javascript


Nit: header isn't needed; let's remove it.

Bump @apawast

JoshuaKGoldberg · 2019-03-02T16:22:52Z

@lupine86 One more suggestion: you sent a PR from your master branch, which means pulling in updates to this repository's master branch can be a little annoying. I'd recommend:

Completely resetting your local master to this repository's
Create a new branch, say azure-pipelines, off that reset master
Copying the changes you added in this PR on a commit on that branch
Sending a similar PR from that branch to this repository
Deleting this PR

I'm basing this suggestion off the reported 210 commit difference in your branch on this PR, since it looks like something went wrong in Git land. Apologies if you already knew this!

apawast · 2019-03-04T19:03:35Z

@JoshuaKGoldberg I've addressed your feedback so far. Please let me know if there's anything else, if not I'll make a new PR and branch. I ran into some issues when I was trying to squash the commits and it had unexpected effects and says I made 210 commits even though they're not mine. The only thing that's different right now is the package-lock.json file but that should fix itself when I reset things.

JoshuaKGoldberg · 2019-03-04T19:18:40Z

Yup, looks good! Once the package.json and package-lock.json changes are undone it looks like we can merge this in for testing.

JoshuaKGoldberg

Other than package merge shenanigans, this looks like the only remaining item.

JoshuaKGoldberg · 2019-03-04T19:18:12Z

azure-pipelines.yml

+# Node.js
+# Build a general Node.js project with npm.
+# Add steps that analyze code, save build artifacts, deploy, and more:
+# https://docs.microsoft.com/azure/devops/pipelines/languages/javascript


Bump @apawast

JoshuaKGoldberg · 2019-03-07T02:21:29Z

Super, thanks for making progress on this! Closing this PR in favor of #838.

azure-pipelines bot and others added 3 commits November 20, 2018 16:16

Set up CI with Azure Pipelines

f9f9818

Set up CI Tests with Azure Pipelines

41d2922

add missing newline at EOF

77a7234

JoshuaKGoldberg previously requested changes Nov 26, 2018

View reviewed changes

apawast added 17 commits February 21, 2019 17:20

Rebased and merging

62ff6fa

adding windown/linux and multiple versions of node for CI

e9a8a66

fixing typo

c2f433d

Changed the structure of jobs setup in yml

37a02b1

Fixing the matrix in ym

824bee8

regenerated package-lock.json

6443db9

Removing lint jobs

fbc533a

fixing publish test task

2939487

adding a node 11 job

1434029

Added test result file for mocha

5bf79bb

trying to publish test results

570e759

changed the test script and deleted a test result file

4234ba7

trying to fix test results

f1f24a0

trying to fix test results

d1b3804

trying to fix test results

b28528c

trying to fix test results

9a278b9

trying to fix test results

f19a68a

Josh Goldberg and others added 15 commits February 26, 2019 11:25

Removed mentions of the npm-*.*.* and releases branches from Releases

b914d14

6.0.0-beta0

63a8d95

6.0.0-beta

3b5fd9c

Re-added releases branch

bda0afc

Separated 6.0.0-beta's lists into sections

dcb3347

6.0.0

6aee5e9

Strict order of rules in README.md (microsoft#817)

124aeb5

* Validate order of rules in README.md (fixes microsoft#816) * Fix rules order in README.md * create-rule task also updates README (fixed microsoft#816) * Update CONTRIBUTING.md with detais about README.md actions (fixes microsoft#648)

port react unused props state tests to new infrastructure (microsoft#826

366893b

) * ported react-unused-props-and-state tests to new test framework * removed react-unused-props-and-state tests from old framework

Add changelog for 6.1.0-beta release (microsoft#827)

4200c51

Update package version (microsoft#828)

c372f36

Merge branch 'master' of https://github.com/lupine86/tslint-microsoft…

75411a2

…-contrib

Regenerated package-lock.json

1ad8881

JoshuaKGoldberg mentioned this pull request Mar 2, 2019

Request: Build, Test and Release tslint-microsoft-contrib using Azure Pipelines #656

Closed

JoshuaKGoldberg suggested changes Mar 2, 2019

View reviewed changes

apawast added 2 commits March 4, 2019 11:27

Addressing feedback from pr

179ef45

changing test script to include junit test

79029f8

JoshuaKGoldberg reviewed Mar 4, 2019

View reviewed changes

apawast added 2 commits March 6, 2019 09:48

New solution for reporter and publishing tests

753d7ac

adding config for reporter

1ded4b5

apawast mentioned this pull request Mar 6, 2019

Azure pipelines #838

Merged

4 tasks

JoshuaKGoldberg closed this Mar 7, 2019

JoshuaKGoldberg added this to the None milestone Apr 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set up CI with Azure Pipelines #655

Set up CI with Azure Pipelines #655

lupine86 commented Nov 20, 2018 •

edited by JoshuaKGoldberg

Loading

IllusionMH commented Nov 20, 2018

JoshuaKGoldberg commented Nov 21, 2018

IllusionMH commented Nov 21, 2018

lupine86 commented Nov 26, 2018

JoshuaKGoldberg commented Nov 26, 2018

JoshuaKGoldberg left a comment •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg Mar 2, 2019

JoshuaKGoldberg Mar 2, 2019

JoshuaKGoldberg Mar 2, 2019

JoshuaKGoldberg Mar 4, 2019

JoshuaKGoldberg commented Mar 2, 2019

apawast commented Mar 4, 2019

JoshuaKGoldberg commented Mar 4, 2019

JoshuaKGoldberg left a comment

JoshuaKGoldberg Mar 4, 2019

JoshuaKGoldberg commented Mar 7, 2019

Set up CI with Azure Pipelines #655

Set up CI with Azure Pipelines #655

Conversation

lupine86 commented Nov 20, 2018 • edited by JoshuaKGoldberg Loading

PR checklist

Overview of change:

Is there anything you'd like reviewers to focus on?

IllusionMH commented Nov 20, 2018

JoshuaKGoldberg commented Nov 21, 2018

IllusionMH commented Nov 21, 2018

lupine86 commented Nov 26, 2018

JoshuaKGoldberg commented Nov 26, 2018

JoshuaKGoldberg left a comment • edited Loading

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Mar 2, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg Mar 2, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg Mar 2, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg Mar 4, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg commented Mar 2, 2019

apawast commented Mar 4, 2019

JoshuaKGoldberg commented Mar 4, 2019

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Mar 4, 2019

Choose a reason for hiding this comment

JoshuaKGoldberg commented Mar 7, 2019

lupine86 commented Nov 20, 2018 •

edited by JoshuaKGoldberg

Loading

JoshuaKGoldberg left a comment •

edited

Loading