Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

#278 Implement react-a11y-no-onchange. #543

Merged
merged 5 commits into from
Oct 16, 2018

Conversation

sahalsaad
Copy link
Contributor

Fixes #278

  • OnChange event handler should not be used with the select element.

@msftclas
Copy link

msftclas commented Oct 12, 2018

CLA assistant check
All CLA requirements met.

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! Just a couple of comments on the rule's metadata.

src/reactA11yNoOnchangeRule.ts Outdated Show resolved Hide resolved
src/reactA11yNoOnchangeRule.ts Outdated Show resolved Hide resolved
@sahalsaad
Copy link
Contributor Author

sahalsaad commented Oct 15, 2018

Updated my PR. Let me know if you have a better description. I can update it.

Edit: I not really sure why the test failed. I run it locally all passed.

@sahalsaad sahalsaad force-pushed the react-a11y-no-onchange branch from 0aaf6ec to e8dcfee Compare October 15, 2018 02:16
@JoshuaKGoldberg
Copy link

why the test failed

An unrelated PR was merged in that touched pretty much every test file, so you'll have to change your unit tests slightly.

In failure case assertions, instead of:

name: 'file.ts',

...you'll want:

Utils.absolutePath('file.ts')

@sahalsaad sahalsaad force-pushed the react-a11y-no-onchange branch from 2298122 to a5f4d23 Compare October 15, 2018 15:40
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💖

@JoshuaKGoldberg JoshuaKGoldberg merged commit 43b6b3c into microsoft:master Oct 16, 2018
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants