-
Notifications
You must be signed in to change notification settings - Fork 198
new security rule: detect-child-process #252
Comments
I'd like to help, how can I contribute @JoshuaKGoldberg ? I assume it's an implementation of an ESLint functionality to TSLint? |
Heya @jasperdanan, glad to have you contribute! Correct. The This isn't quite a copy & paste job, since the ASTs for ESLint and TSLint are different, but the functionality should be about the same. Is that enough info to go off of? |
Yep! Though I'm wondering if this https://github.com/Microsoft/tslint-microsoft-contrib/blob/master/src/nonLiteralRequireRule.ts is an implimentatiion of https://github.com/nodesecurity/eslint-plugin-security/blob/master/rules/detect-non-literal-require.js ? Just so I can draw a parallel between the two Linter rules. Where should I put the new rule? Under |
Yup, that's correct. It looks like ours is checking for arrays passed to require, but otherwise they're roughly the same.
Yup! #543 is a good example of what you'll want to add:
The Let me know if that's not the right or not enough information to go off of! |
https://github.com/nodesecurity/eslint-plugin-security/blob/master/rules/detect-child-process.js
The text was updated successfully, but these errors were encountered: