Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Record test start/end events for data driven tests" #673

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jan 10, 2020

Reverts #631
Reverts the PR because master fails in compat tests after the PR was merged.

@nohwnd nohwnd requested a review from NGloreous January 10, 2020 12:17
@NGloreous
Copy link
Contributor

@nohwnd what's failing?

@nohwnd
Copy link
Member Author

nohwnd commented Jan 10, 2020

/azp run TestFx.CI

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@nohwnd
Copy link
Member Author

nohwnd commented Jan 10, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd
Copy link
Member Author

nohwnd commented Jan 10, 2020

@NGloreous sorry for the lack of info, I was busy with release when I was reverting this.

This is where it started failing this build which was triggered after merging your PR to master. It fails on RunAllCompatTests.

I was trying to fix it in #671 because I hoped it will be just a quick fix (the original error I saw was just a missing parameter on a method call), but it turned out that the error is cryptic because the test base does not print errors when they are written in the log. So the message in the above build is confusing (because no tests were run, so they are none are in the list) and the error is actually this.

If you have any insight into how to fix this, please help me out in #671, so we can revert back the commit I am reverting here. 🙂

@NGloreous
Copy link
Contributor

@nohwnd thanks for taking care of this and sorry for the hassle. I've signed off here. I will take a look at #671 but it may have to wait until later in the week.

@nohwnd
Copy link
Member Author

nohwnd commented Jan 30, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd nohwnd merged commit 3c570cc into master Jan 30, 2020
@Haplois Haplois deleted the revert-631-user/nglore/teststartend branch January 27, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants