-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Record test start/end events for data driven tests" #673
Conversation
This reverts commit 6c1ee30.
@nohwnd what's failing? |
/azp run TestFx.CI |
No pipelines are associated with this pull request. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@NGloreous sorry for the lack of info, I was busy with release when I was reverting this. This is where it started failing this build which was triggered after merging your PR to master. It fails on RunAllCompatTests. I was trying to fix it in #671 because I hoped it will be just a quick fix (the original error I saw was just a missing parameter on a method call), but it turned out that the error is cryptic because the test base does not print errors when they are written in the log. So the message in the above build is confusing (because no tests were run, so they are none are in the list) and the error is actually this. If you have any insight into how to fix this, please help me out in #671, so we can revert back the commit I am reverting here. 🙂 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Reverts #631
Reverts the PR because master fails in compat tests after the PR was merged.