Fix build

[nohwnd]

Fix build failing after merged pull request.

[nohwnd]

Error Message:
 Test method MSTestAdapter.Smoke.E2ETests.CompatTests.RunAllCompatTests threw exception: 
System.InvalidOperationException: Test run ended with 1 errors.
An exception occurred while invoking executor 'executor://mstestadapter/v2': 3 arguments were passed to 'Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner::RunSingleTest'. 2 arguments were expected by this method.
Stack Trace:
    at Microsoft.MSTestV2.CLIAutomation.RunEventsHandler.EnsureSuccess() in D:\a\1\s\test\E2ETests\Automation.CLI\RunEventsHandler.cs:line 125
   at Microsoft.MSTestV2.CLIAutomation.CLITestBase.InvokeVsTestForExecution(String[] sources, String runSettings, String testCaseFilter) in D:\a\1\s\test\E2ETests\Automation.CLI\CLITestBase.cs:line 80
   at MSTestAdapter.Smoke.E2ETests.CompatTests.RunAllCompatTests() in D:\a\1\s\test\E2ETests\Smoke.E2E.Tests\CompatTests.cs:line 34

The build fails becase the api is no longer compatible with the api published by the legacy adapter that is used in the test. Investigating what is the best way to fix this.

[nohwnd]

@AbhitejJohn I can't figure this out, I can't locate where exactly it fails and figure out how to better debug this. Any suggestions how to approach this?

To me it seems that we are invoking the Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.Execution.UnitTestRunner::RunSingleTest indirectly via reflection, but the number of parameters is not correct because we probably take the information about the method from the new type (with 3 parameters) and trying to invoke an older version of the type (which has 2 parameters). But as I said this is just me guessing what could be the problem. I tried debugging this in multiple ways (replacing the dlls, generating pdbs, attaching vs to the child process) but none of them allowed me to see where exactly it fails.

[AbhitejJohn]

@nohwnd: Sorry I usually tend to miss github tags. Please hit me up on teams if you need anything I haven't responded on. This specific issue does indeed sound like we have two different versions of the adapter on either side of the app domain which is a recipe for disaster. I dont know if these smoke tests test the adapter against its latest self - It ideally should. Maybe that's the problem.

[nohwnd]

@AbhitejJohn no problem, it's stale, I ended up fixing it and we even discussed it in an internal mail thread about how to evolve the test platform interfaces. :)

The problem is what you described, there is non-explicit dependency on an interface, and because we compile against one version of the library, but end up resolving to another version it fails when non compatible change is done to that interface. Closing this.

[AbhitejJohn]

ah sounds good.