Fix failing HyperlinkIdConsistency unit test

[j4james]

Summary of the Pull Request

This fixes a typo in the HyperlinkIdConsistency unit test which was causing that test to fail. It was mistakenly using a / instead of \ for the string terminator sequences.

References

The test initially worked because of a bug in the state machine parser, but that bug was recently fixed in PR #7340.

PR Checklist

• Closes HyperlinkIdConsistency unit test is failing #7654
• CLA signed.
• Tests passed
• Documentation updated.
• Schema updated.
• I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

Validation Steps Performed

I've run the test again and it now passes.

[DHowett]

Thanks for catching & fixing this. It shall act as a reminder that weirdly these tests may not be running in CI? That’s unsettling. :)

[PankajBhojwani]

Thank you for catching this!

[ghost]

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 4 hours 17 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[carlos-zamora]

@msftbot merge this in 1 minute

[ghost]

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Thu, 17 Sep 2020 16:51:56 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[j4james]

Thanks for catching & fixing this. It shall act as a reminder that weirdly these tests may not be running in CI? That’s unsettling. :)

That was my concern too, but I think it's just a matter of unlucky timing. When PR #7340 was first created the hyperlink PR hadn't yet been merged, so the problem was only exposed once they were both merged together in master. If we want to prevent issues like this, we'd need to require that all PRs rebase or merge from master prior to being approved. I don't know if that's worth the hassle.

[skyline75489]

We have something like that in AzureDevOps which will reset the CI state of PRs when there’s new commit merged in the target branch. Wonder if GitHub has this, too.

[DHowett]

We used to have a rule like this. It hurts our velocity too much 😄 and I'm willing to accept a little breakage from merges that expose eachothers' issues.