Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HyperlinkIdConsistency unit test is failing #7654

Closed
j4james opened this issue Sep 17, 2020 · 0 comments · Fixed by #7655
Closed

HyperlinkIdConsistency unit test is failing #7654

j4james opened this issue Sep 17, 2020 · 0 comments · Fixed by #7655
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@j4james
Copy link
Collaborator

j4james commented Sep 17, 2020

Environment

Windows build number: Version 10.0.18362.1016
Windows Terminal version (if applicable): Commit f91b53d

Steps to reproduce

  1. Build commit f91b53d
  2. Run the unit test: runut /name:*HyperlinkIdConsistency*

Expected behavior

The test should pass.

Actual behavior

The test fails when verifying the output of the initial escape sequence:

Expected =      "^[]8;id=1364-1;http://example.com^[\"
Actual =        "ink"

Technically the test was always broken, but it managed to pass when it was initially added because of a bug in the state machine parser. I think that bug was recently fixed by PR #7340, which is why the test has only started failing now.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 17, 2020
@j4james j4james mentioned this issue Sep 17, 2020
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 17, 2020
@ghost ghost closed this as completed in #7655 Sep 17, 2020
ghost pushed a commit that referenced this issue Sep 17, 2020
@j4james
Fix failing HyperlinkIdConsistency unit test (#7655)
c033594 
## Summary of the Pull Request

This fixes a typo in the `HyperlinkIdConsistency` unit test which was causing that test to fail. It was mistakenly using a `/` instead of `\` for the string terminator sequences.

## References

The test initially worked because of a bug in the state machine parser, but that bug was recently fixed in PR #7340.

## PR Checklist
* [x] Closes #7654
* [x] CLA signed. 
* [x] Tests passed
* [ ] Documentation updated. 
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan.

## Validation Steps Performed

I've run the test again and it now passes.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 17, 2020
@DHowett DHowett mentioned this issue Sep 17, 2020
Merged
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failing HyperlinkIdConsistency unit test j4james/terminal
1 participant
@j4james