Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TermControl: set the scrollbar jump distance to one screenful #7385

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Aug 24, 2020

Most applications with scrollable content seem to define the "large
jump" distance as about a screenful of content. You can see this in long
pages in Settings and documents in Notepad.

We just weren't configuring ScrollBar here.

Fixes #7367

PR Checklist

Most applications with scrollable content seem to define the "large
jump" distance as about a screenful of content. You can see this in long
pages in Settings and documents in Notepad.

We just weren't configuring ScrollBar here.

Fixes #7367
@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Aug 24, 2020
@DHowett DHowett changed the title TermControl: set the jump distance to one screenful on the scrollbar TermControl: set the scrollbar jump distance to one screenful Aug 24, 2020
@DHowett DHowett merged commit a5bed25 into master Aug 24, 2020
@DHowett DHowett deleted the dev/duhowett/scrolljump branch August 24, 2020 22:54
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 26, 2020
@vefatica
Copy link

A bit OT but is there a difference between a store download and a GitHub download?

Thanks!

  • Vince

@DHowett
Copy link
Member Author

DHowett commented Aug 26, 2020

Nope!

@vefatica
Copy link

Thanks. How about "Windows Terminal" vs. "Windows Terminal Preview"?

@DHowett
Copy link
Member Author

DHowett commented Aug 26, 2020

Preview is one month "newer" than stable. Preview gets features faster, but might be a little less polished.

@vefatica
Copy link

I have a lot of trouble with the store. Where's the preview on GitHub?

@vefatica
Copy link

I got it from GitHub. It's installed. I can launch it from the install dialog (doesn't seem to find my settings.json). WT.TXT still opens v1.1.2233.

@DHowett
Copy link
Member Author

DHowett commented Aug 26, 2020

  1. preview uses a separate settings file because it is a separate program
  2. you can go to "manage app execution aliases" to configure which version of terminal wt runs

image

image

@vefatica
Copy link

Thanks, Dustin! "Manage app execution aliases" ... that works. I had never been there before. Is there an "ms-settings:" way to get there? I dislike the start button!

And (as you know) this issue is fixed.

@DHowett
Copy link
Member Author

DHowett commented Aug 26, 2020

That's the only settings page that there is not a ms-settings link for. Seriously. I checked. I wanted to put it in our documentation. 😄

@vefatica
Copy link

Thanks again. Is there a ms-settings link for apps (that would be pretty close)? Where can I find a comprehensive list of ms-settings links?

@vefatica
Copy link

vefatica commented Aug 26, 2020

Never mind. "ms-settings:appsfeatures" works. And I found a list of URIs on the web.

https://4sysops.com/wiki/list-of-ms-settings-uri-commands-to-open-specific-settings-in-windows-10/history/?revision=1555540

@vefatica
Copy link

If the app execution alias points to one, how do I run the other (easily)?

@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 28, 2020

From the commandline? There's not an easy way. From the Start Menu, it's easy enough
image

Out of curiosity, why would you want to be able to run both preview and stable side-by-side?

@vefatica
Copy link

I wouldn't call the Start Menu easy. But I can automate that with any of a few apps that send keystrokes.

Why run them both ... just because I can. :-)

I noticed one difference between the stable version and the preview. Starting the stable version (1.1.2233.0) causes the "LicenseManager" and "ClipSVC" services to start. Starting the preview does not cause those services to start. I am curious about that.

Is there any Win32 API interface with the app execution alias mechanism?

@vefatica
Copy link

vefatica commented Sep 1, 2020

I noticed one difference between the stable version and the preview. Starting the stable version (1.1.2233.0) causes the "LicenseManager" and "ClipSVC" services to start. Starting the preview does not cause those services to start. I am still curious about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll via click in scroll bar?
4 participants