Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll via click in scroll bar? #7367

Closed
vefatica opened this issue Aug 21, 2020 · 6 comments · Fixed by #7385
Closed

Scroll via click in scroll bar? #7367

vefatica opened this issue Aug 21, 2020 · 6 comments · Fixed by #7385
Assignees
@DHowett
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@vefatica
Copy link

When I click in terminal's vertical scroll bar, above or below the slider, the window scrolls 4 lines. In most other places, including the Window's console, such a click results in the window scrolling 1 page. Is this by design? Do I have any control over it? - Vince
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 21, 2020
@DHowett DHowett self-assigned this Aug 23, 2020
@DHowett DHowett added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Aug 23, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 23, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 23, 2020
@DHowett
Copy link
Member

DHowett commented Aug 23, 2020

Yep, this is a simple fix. Good catch! 😄

@vefatica
Copy link
Author

I'm surprised it wasn't caught earlier.

How do I submit a feature suggestion/request?

Thanks. - Vince

@DHowett
Copy link
Member

DHowett commented Aug 23, 2020

We can use this issue (which I've left open) to track fixing the scroll bar. There's no need for you to file a separate suggestion if it's about the same problem 😄

We use this issue tracker for all feature requests, tasks, bugs, scenarios, etc.

@vefatica

This comment has been minimized.

Sign in to view
@vefatica

This comment has been minimized.

Sign in to view
DHowett added a commit that referenced this issue Aug 24, 2020
@DHowett
TermControl: set the jump distance to one screenful on the scrollbar
03c234d 
Most applications with scrollable content seem to define the "large
jump" distance as about a screenful of content. You can see this in long
pages in Settings and documents in Notepad.

We just weren't configuring ScrollBar here.

Fixes #7367
@DHowett DHowett mentioned this issue Aug 24, 2020
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 24, 2020
DHowett added a commit that referenced this issue Aug 24, 2020
@DHowett
TermControl: set the scrollbar jump distance to one screenful (#7385)
a5bed25 
Most applications with scrollable content seem to define the "large
jump" distance as about a screenful of content. You can see this in long
pages in Settings and documents in Notepad.

We just weren't configuring ScrollBar here.

Fixes #7367
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 24, 2020
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7385, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett DHowett

Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TermControl: set the scrollbar jump distance to one screenful microsoft/terminal
2 participants
@DHowett @vefatica