Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update colour picker buttons with round edges. #7305

Merged
1 commit merged into from
Aug 18, 2020
Merged

Update colour picker buttons with round edges. #7305

1 commit merged into from
Aug 18, 2020

Conversation

MichelleTanPY
Copy link
Contributor

@MichelleTanPY MichelleTanPY commented Aug 15, 2020 •
edited by DHowett
Loading

RoundedButtons

Validation Steps Performed

Deployed locally and verified that the colour picker's button has round edges.

Closes #7142

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 15, 2020
DHowett
DHowett approved these changes Aug 16, 2020
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is great. I didn’t realize there was an attribute for us to set!

Chips1234
Chips1234 suggested changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@Chips1234 Chips1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want a conditional namespace (since CornerRadius is not supported with older devices)

@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 16, 2020
@MichelleTanPY
Copy link
Contributor Author

@Chips1234 Ok, which conditional namespace should I use? Like a condition to check if "CornerRadius" attribute exists?
(Sorry I'm not too familiar with XAML)

@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 16, 2020
@Chips1234
Copy link
Contributor

Chips1234 commented Aug 16, 2020 via email •
edited by ghost
Loading

Chips1234
Chips1234 approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@Chips1234 Chips1234 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I don't think you need a conditional namespace

@DHowett
Copy link
Member

DHowett commented Aug 18, 2020

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 18, 2020
@ghost
Copy link

ghost commented Aug 18, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 18 Aug 2020 00:20:35 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit baefa46 into microsoft:master Aug 18, 2020
MichelleTanPY added a commit to MichelleTanPY/terminal that referenced this pull request Aug 18, 2020
@MichelleTanPY
Update colour picker buttons with round edges. (microsoft#7305)
37282cf 
![RoundedButtons](https://user-images.githubusercontent.com/41475767/90323225-39e96500-df56-11ea-9219-d386f74fc1b4.png)

## Validation Steps Performed
Deployed locally and verified that the colour picker's button has round edges.

Closes microsoft#7142
DHowett pushed a commit that referenced this pull request Aug 24, 2020
@MichelleTanPY @DHowett
Update colour picker buttons with round edges. (#7305)
a02768b 
![RoundedButtons](https://user-images.githubusercontent.com/41475767/90323225-39e96500-df56-11ea-9219-d386f74fc1b4.png)

## Validation Steps Performed
Deployed locally and verified that the colour picker's button has round edges.

Closes #7142

(cherry picked from commit baefa46)
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal v1.2.2381.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 26, 2020
Closed
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chips1234 Chips1234 Chips1234 approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Round edges for colour picker's "Reset" and "Custom" buttons
4 participants
@MichelleTanPY @Chips1234 @DHowett @zadjii-msft