Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round edges for colour picker's "Reset" and "Custom" buttons #7142

Closed
Chips1234 opened this issue Jul 31, 2020 · 2 comments · Fixed by #7305
Closed

Round edges for colour picker's "Reset" and "Custom" buttons #7142

Chips1234 opened this issue Jul 31, 2020 · 2 comments · Fixed by #7305
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@Chips1234
Copy link
Contributor

Description of the new feature/enhancement

The "Reset" and "Custom" buttons should have CornerRadius of 2, like the other buttons.
CornerRadius on Colour Picker
@Chips1234 Chips1234 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 31, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jul 31, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Aug 3, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 3, 2020
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Aug 3, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 3, 2020
@MichelleTanPY MichelleTanPY mentioned this issue Aug 15, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 15, 2020
@ghost ghost closed this as completed in #7305 Aug 18, 2020
@ghost ghost removed the In-PR This issue has a related PR label Aug 18, 2020
ghost pushed a commit that referenced this issue Aug 18, 2020
@MichelleTanPY
Update colour picker buttons with round edges. (#7305)
baefa46 
![RoundedButtons](https://user-images.githubusercontent.com/41475767/90323225-39e96500-df56-11ea-9219-d386f74fc1b4.png)

## Validation Steps Performed
Deployed locally and verified that the colour picker's button has round edges.

Closes #7142
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 18, 2020
MichelleTanPY added a commit to MichelleTanPY/terminal that referenced this issue Aug 18, 2020
@MichelleTanPY
Update colour picker buttons with round edges. (microsoft#7305)
37282cf 
![RoundedButtons](https://user-images.githubusercontent.com/41475767/90323225-39e96500-df56-11ea-9219-d386f74fc1b4.png)

## Validation Steps Performed
Deployed locally and verified that the colour picker's button has round edges.

Closes microsoft#7142
DHowett pushed a commit that referenced this issue Aug 24, 2020
@MichelleTanPY @DHowett
Update colour picker buttons with round edges. (#7305)
a02768b 
![RoundedButtons](https://user-images.githubusercontent.com/41475767/90323225-39e96500-df56-11ea-9219-d386f74fc1b4.png)

## Validation Steps Performed
Deployed locally and verified that the colour picker's button has round edges.

Closes #7142

(cherry picked from commit baefa46)
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7305, which has now been successfully released as Windows Terminal v1.2.2381.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7305, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Update colour picker buttons with round edges. MichelleTanPY/terminal
3 participants
@DHowett @zadjii-msft @Chips1234