Add some polish to nested commands in the command palette #7299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-User Interface
DHowett
approved these changes
Aug 15, 2020
| @@ -12,6 +12,7 @@ namespace TerminalApp | |||
| String NoMatchesText { get; }; | |||
| String SearchBoxText { get; }; | |||
| String ControlName { get; }; | |||
| String ParentCommandName { get; }; | |||
There was a problem hiding this comment.
future: we may want to display the icon if it has one, too.
| @@ -236,6 +249,21 @@ the MIT License. See LICENSE in the project root for license information. --> | |||
| Text="{x:Bind KeyChordText, Mode=OneWay}" /> | |||
| </Border> | |||
|
|
|||
| <!-- xE70E is ChevronUp. Rotated 90 degrees, it's _ChevronRight_ --> | |||
ghost
requested review from
miniksa,
carlos-zamora,
leonMSFT and
PankajBhojwani
leonMSFT
approved these changes
Aug 18, 2020
zadjii-msft
added
the
AutoMerge
|
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
References
PR Checklist
Validation Steps Performed
look at that gif