Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A nested cmdpal menu should show the parent command above the list of commands #7265

Closed
zadjii-msft opened this issue Aug 12, 2020 · 2 comments · Fixed by #7299
Closed

A nested cmdpal menu should show the parent command above the list of commands #7265

zadjii-msft opened this issue Aug 12, 2020 · 2 comments · Fixed by #7299
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

Follow-up to #6856

mockup:

image

I'm talking about the "Split pane with... > " label in the above mockup.

Did that mock-up take longer than implementing it would have? Perhaps!
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. good first issue This is a fix that might be easier for someone to do as a first contribution labels Aug 12, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 12, 2020
This was referenced Aug 12, 2020
Merged
Open
@DHowett
Copy link
Member

DHowett commented Aug 12, 2020

This is a hilarious mockup. 😄

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 12, 2020
@DHowett DHowett added this to the Terminal v2.0 milestone Aug 12, 2020
@zadjii-msft zadjii-msft mentioned this issue Aug 14, 2020
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Aug 14, 2020
@ghost ghost closed this as completed in #7299 Aug 18, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 18, 2020
ghost pushed a commit that referenced this issue Aug 18, 2020
@zadjii-msft
Add some polish to nested commands in the command palette (#7299)
3d64921 
## Summary of the Pull Request

![cmdpal-nested-command-polish](https://user-images.githubusercontent.com/18356694/90293616-1f29ca00-de4a-11ea-8942-00d255de929a.gif)


* Add a chevron for nested commands
* Add the text of the parent command when entering a child command

## References

## PR Checklist
* [x] Closes #7265
* [x] I work here
* [n/a] Tests added/passed
* [n/a] Requires documentation to be updated

## Validation Steps Performed
_look at that gif_
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7299, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal good first issue This is a fix that might be easier for someone to do as a first contribution Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Add some polish to nested commands in the command palette microsoft/terminal
2 participants
@DHowett @zadjii-msft