Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default initialize a CmdPal mode #7263

Merged
3 commits merged into from
Aug 12, 2020
Merged

Default initialize a CmdPal mode #7263

3 commits merged into from
Aug 12, 2020

Conversation

leonMSFT
Copy link
Contributor

@leonMSFT leonMSFT commented Aug 12, 2020

Whoops, members are zero initialized in Debug builds but most likely not
in Release builds So, this PR adds a couple of default values to
_currentMode and its associated XAML strings to make cmdpal/ats work
deterministically on first use. I also added a default value to
_anchorKey just to be safe.

Closes #7254

@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Aug 12, 2020
@leonMSFT leonMSFT added this to the Terminal v1.3 milestone Aug 12, 2020
@zadjii-msft zadjii-msft removed their assignment Aug 12, 2020
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in love with how we have to set the text in multiple places. Is it possible to centralize how the text is set to the right text for the mode?

src/cascadia/TerminalApp/CommandPalette.cpp Outdated Show resolved Hide resolved
src/cascadia/TerminalApp/CommandPalette.cpp Outdated Show resolved Hide resolved
@leonMSFT
Copy link
Contributor Author

Oh absolutely, I should've been using _switchToMode actually!

@leonMSFT leonMSFT added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 12, 2020
@ghost
Copy link

ghost commented Aug 12, 2020

Hello @leonMSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 3 hours 5 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Aug 12, 2020

@msftbot merge this in 5 minutes

@ghost
Copy link

ghost commented Aug 12, 2020

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 12 Aug 2020 23:24:58 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 93ae6b6 into master Aug 12, 2020
@ghost ghost deleted the dev/lelian/ats-uninit-mode branch August 12, 2020 23:25
@ghost
Copy link

ghost commented Aug 26, 2020

🎉Windows Terminal Preview v1.3.2382.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command palette no longer shows "no matching commands"
6 participants