Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command palette no longer shows "no matching commands" #7254

Closed
DHowett opened this issue Aug 12, 2020 · 1 comment · Fixed by #7263
Closed

Command palette no longer shows "no matching commands" #7254

DHowett opened this issue Aug 12, 2020 · 1 comment · Fixed by #7263
Assignees
@leonMSFT
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.3

Comments

@DHowett
Copy link
Member

DHowett commented Aug 12, 2020 •
edited
Loading

This is a likely regression from #6732

image
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Aug 12, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 12, 2020
@DHowett DHowett added this to the Terminal v1.3 milestone Aug 12, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 12, 2020
@leonMSFT leonMSFT mentioned this issue Aug 12, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 12, 2020
@ghost ghost closed this as completed in #7263 Aug 12, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 12, 2020
ghost pushed a commit that referenced this issue Aug 12, 2020
@leonMSFT
Default initialize a CmdPal mode (#7263)
93ae6b6 
Whoops, members are zero initialized in Debug builds but most likely not
in Release builds So, this PR adds a couple of default values to
`_currentMode` and its associated XAML strings to make cmdpal/ats work
deterministically on first use.  I also added a default value to
`_anchorKey` just to be safe.

Closes #7254
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7263, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonMSFT leonMSFT

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.3
Development

Successfully merging a pull request may close this issue.

Default initialize a CmdPal mode microsoft/terminal
3 participants
@DHowett @zadjii-msft @leonMSFT