Add suppressApplicationTitle setting #2750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
approved these changes
Sep 14, 2019
DHowett-MSFT
suggested changes
Sep 15, 2019
There was a problem hiding this comment.
I think it's more reasonable to make suppressApplicationTitle a boolean, and if it's true then tabTitle becomes the "winning" title over the app title. Otherwise, you end up with four places you can set the title (in order of most-winning: name, tabTitle, application, suppressApplicationTitle). The original design from @zadjii-msft suggested a boolean as well.
| const auto lastFocusedProfile = tab->GetFocusedProfile().value(); | ||
| const auto* const matchingProfile = _settings->FindProfile(lastFocusedProfile); | ||
|
|
||
| const auto suppressApplicationTitle = matchingProfile->GetSuppressApplicationTitle(); |
There was a problem hiding this comment.
You need a null check here: since matchingProfile is a pointer type, it could be nullptr. That'd indicate that the profile was removed from settings (!) before this happened.
ghost
added
the
Needs-Author-Feedback
cinnamon-msft
force-pushed
the
cinnamon/suppress-tab-title
branch
from
0b89dc0
to
5f0d0b7
Compare
ghost
removed
the
Needs-Author-Feedback
|
Recreated PR with boolean functionality in #2814 |
|
But whyyyy couldn’t that be a revision to the existing PR |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Added
suppressApplicationTitleas an optional profile settingWill override
tabTitleif setJSON schema will need to be updated once it's merged
References
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Set both
tabTitleandsuppressApplicationTitle->suppressApplicationTitlewon outSet only
suppressApplicationTitle->suppressApplicationTitlewon out