Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"suppressApplicationTitle" doesn't work (or exist.) #2645

Closed
aedm opened this issue Sep 3, 2019 · 10 comments · Fixed by #2814
Closed

"suppressApplicationTitle" doesn't work (or exist.) #2645

aedm opened this issue Sep 3, 2019 · 10 comments · Fixed by #2814
Assignees
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone

Comments

@aedm
Copy link

aedm commented Sep 3, 2019

Environment

Windows 10.0.18362.0
Terminal: 0.4.2382.0

Steps to reproduce

  1. Add custom, permanent tab titles for some of the profiles:
  "tabTitle" : "gateway",
  "suppressApplicationTitle": true,
  1. Start a new application in these tabs.

I took the syntax from the PR by @zadjii-msft: #2373 (comment)

Expected behavior

Tab titles don't change, they keep the value specified in tabTitle, just like they used to in Terminal 0.3.x.

Actual behavior

Tab titles change to reflect the currently running program.

Here I'm running three different applications using npm start. I've set up a different, useful tabTitle for all of these tabs, but all I see is this:

image

Note

From #2373: "d. We'll add suppressApplicationTitle when someone complains" <- Here I am. :)

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 3, 2019
@aedm aedm changed the title suppressApplicationTitle not working "suppressApplicationTitle" doesn't work Sep 3, 2019
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Sep 3, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Sep 3, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 3, 2019
@rkevingibson
Copy link

Strong upvote for this. This most recent update made my nice short tab titles into 80 character long beasts when using razzle, and they all contain useless information.

@DHowett-MSFT
Copy link
Contributor

@rkevingibson you knwo you can use the title command (from CMD) to reset them, right? PowerShell also affords $Host.UI.RawUI.Title. A lot of these are better options than a strict override, unless the application has absolutely no other way of fixing the title. It's a huge hammer.

@aedm
Copy link
Author

aedm commented Sep 6, 2019

@DHowett-MSFT It would be a very good solution, but it doesn't always work. Some apps like npm completely override title.

2019-09-06_16-18-27

@encladeus
Copy link

encladeus commented Sep 6, 2019

@DHowett-MSFT as mentioned by @aedm, I too have observed issues whereby tabTitle and the title command in the command prompt are overridden dynamically. Sometimes at the end of running a batch file to build code from the command line, after the title has changed dynamically in the tab, it may or may not revert back to the title set before the batch file was run.

For example, after setting title to x64, as also defined in tabTitle, the following happens while the batch file is running (for several minutes).
title2

So in the case above the title eventually reverted back to x64, but this one didn't revert back to x86 (shown in previous image) after completion of the batch file. Also, note the disappearance of Administrator:
title1

I definitely prefer a method, perhaps by using tabTitle and suppressApplicationTitle = true so that once set it never changes. Meanwhile, it also looks like something is not working as expected.

@bitcrazed bitcrazed removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 9, 2019
@ghost ghost added the In-PR This issue has a related PR label Sep 13, 2019
@ghost ghost removed the Help Wanted We encourage anyone to jump in on these. label Sep 24, 2019
@timespinner
Copy link

timespinner commented Oct 26, 2019

I know this is not directly related to the ticket, but in addition, I would vote for a dynamic solution if the title is not set - have optional tabMinWidth and tabMaxWidth properties, and shorten the width of all tabs, stopping at minWidth as width of the overall terminal decreases. If the overall width increases, increase the width of all tabs until maxWidth is reached. Scrollbars only appear if tabs can't be shortened any more and then disappear where there is enough room. This will ensure that all tabs appear without having to scroll, and still gives you dynamic titles, which is quite critical.

@DHowett-MSFT DHowett-MSFT changed the title "suppressApplicationTitle" doesn't work "suppressApplicationTitle" doesn't work (or exist.) Nov 6, 2019
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Nov 22, 2019
@ghost
Copy link

ghost commented Nov 26, 2019

🎉This issue was addressed in #2814, which has now been successfully released as Windows Terminal Preview v0.7.3291.0.:tada:

Handy links:

@4k3or3et
Copy link

Hi guys,

i just updated Windows Terminal to Version: 0.7.3291.0. I have implemented in the config:

        "commandline" : "%windir%/system32/openssh/ssh.exe [email protected]
        "name" : "My Linux box",
        "tabTitle" : "My Linux box",
        "suppressApplicationTitle" : true,

However when i start new tab with that profile, title still changes to 'OpenSSH SSH client'.

Am i doing something wrong guys?

Thanks for any clues...

@supermartzin
Copy link

Same issue here, the setting doesn't work for me either :(

@asmh1989
Copy link

@4k3or3et i delete tabTitle, it works

@4k3or3et
Copy link

4k3or3et commented Nov 27, 2019

It works with:

"commandline" : "%windir%/system32/openssh/ssh.exe [email protected]

However when you have:

"commandline" : "%windir%/system32/openssh/ssh.exe [email protected] -i path_to_the_authentication_key"

the title still changes...

Anything else i can try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet