Automatically generate an SxS manifest for WindowsTerminal #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
added
Area-Build
DHowett-MSFT
force-pushed
the
dev/duhowett/auto_manifest
branch
from
6ecbb71
to
f625795
Compare
zadjii-msft
approved these changes
Jul 22, 2019
miniksa
approved these changes
Jul 23, 2019
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 23, 2019
5 tasks
mcpiroman
pushed a commit
to mcpiroman/terminal
that referenced
this pull request
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This pull request introduces a cool new (reusable!) rule that automatically generates manifest fragments from resolved assembly references.
PR Checklist
Validation Steps Performed
Manual build and run; dumping the manifest from the executable; verified that it works as admin again.