Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on About dialog when running Terminal unpackaged #2078

Closed
driver1998 opened this issue Jul 24, 2019 · 5 comments · Fixed by #2122
Closed

Crash on About dialog when running Terminal unpackaged #2078

driver1998 opened this issue Jul 24, 2019 · 5 comments · Fixed by #2122
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v0.3

Comments

@driver1998
Copy link

Environment

Windows build number: [run "ver" at a command prompt] 10.0.18941.1001
Windows Terminal version (if applicable): commit 9d36b08b82c67c6965263c63bb83b024c15f3474

Any other software?

I know it is not a supported scenario, but with #2043 we can now run Terminal unpackaged.
And some people might prefer it this way.

Steps to reproduce

Run WindowsTerminal.exe directly, outside of app package.
Click about in the drop down menu.

Expected behavior

The about dialog show up as normal.

Actual behavior

The app crashes.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 24, 2019
@driver1998 driver1998 changed the title Crash on About when running Terminal unpackaged Crash on About dialog when running Terminal unpackaged Jul 24, 2019
@zadjii-msft
Copy link
Member

I'm going to chime in and say if #2043 made this work a little, I kinda want to make sure it keeps working. Before we went open-source, there was a time you could build and run the terminal from the commandline, using unpackaged activation like this. At some point it broke, and we just never had the time to investigate. If #2043 fixes launching, then I'm inclined to leave this open to track fixing this entirely.

@DHowett-MSFT
Copy link
Contributor

This actually also fails in the packaged version. 😄

@zadjii-msft
Copy link
Member

I'm leaving a note to myself here: When the trying to run the terminal unpackaged, the resources.pri from CascadiaPackage is what you need. You can double-click WindowsTerminal.exe when you copy that file out of CascadiaPackage's output into bin\%ARCH%\%CONFIGURATION%, and launch the WindowsTerminal.exe in that folder. Running the WindowsTerminal.exe in the CascadiaPackage directory shockingly doesn't work.

However, I think we only build the resources.pri file if we build CascadiaPackage, so trying to only build WindowsTerminal then running it won't work. Hmmmm.

zadjii-msft added a commit that referenced this issue Jul 25, 2019
@zadjii-msft
Try createing a script to only build the current working directory
ae02a9c 
  Inspired by #2078.

  I wanted to use this for WindowsTerminal, but I can't generate the
  resources.pri from just building WindowsTerminal. Maybe @DHowett-MSFT has
  some ideas.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Jul 25, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone Jul 25, 2019
@zadjii-msft zadjii-msft added the Area-User Interface Issues pertaining to the user interface of the Console or Terminal label Jul 25, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 25, 2019
@zadjii-msft
Copy link
Member

This should maybe block v0.3. You can't open the about dialog at all, so we're going to get 100 dupes for this, and bug reports are going to become impossible to track.

  🌛
💪 💪
  👖

@zadjii-msft zadjii-msft self-assigned this Jul 25, 2019
@zadjii-msft
Copy link
Member

So this seems to be related to the NavigateUri property on the Hyperlinks in the about dialog. If you remove those NavigateUri's, then it'll display just fine (but obviously not work).

Maybe we hack a workaround for now?

zadjii-msft added a commit that referenced this issue Jul 25, 2019
@zadjii-msft
Fix #2078 by removing the NavigateUri's from the hyperlinks
aa0cfa7
@zadjii-msft zadjii-msft mentioned this issue Jul 25, 2019
Closed
2 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Jul 25, 2019
@zadjii-msft zadjii-msft mentioned this issue Jul 26, 2019
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 26, 2019
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 29, 2019
zadjii-msft added a commit that referenced this issue Aug 6, 2019
@zadjii-msft
Create bx.cmd (#2168)
b495ad2 
* Try createing a script to only build the current working directory

  Inspired by #2078.

  I wanted to use this for WindowsTerminal, but I can't generate the
  resources.pri from just building WindowsTerminal. Maybe @DHowett-MSFT has
  some ideas.

* Cleanup for PR

* fix some bugs with building outside a project directory.

* PR nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v0.3
3 participants
@DHowett-MSFT @zadjii-msft @driver1998