Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give spacing marks space #17826

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Give spacing marks space #17826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/tools/GraphemeTableGen/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
}
buf.Append("};\n");

buf.Append($"constexpr uint{trie.Stages[^1].Bits}_t ucdLookup(const char32_t cp) noexcept\n");
buf.Append("constexpr int ucdLookup(const char32_t cp) noexcept\n");
buf.Append("{\n");
foreach (var stage in trie.Stages)
{
Expand Down Expand Up @@ -290,11 +290,10 @@ static Ucd ExtractValuesFromUcd(string path)
};

// There's no "ea" attribute for "zero width" so we need to do that ourselves. This matches:
// Mc: Mark, spacing combining
// Me: Mark, enclosing
// Mn: Mark, non-spacing
// Cf: Control, format
if (generalCategory.StartsWith("M") || generalCategory == "Cf")
if (generalCategory == "Me" || generalCategory == "Mn" || generalCategory == "Cf")
{
width = CharacterWidth.ZeroWidth;
}
Expand Down
Loading
Loading