Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give spacing marks space #17826

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Give spacing marks space #17826

merged 1 commit into from
Aug 29, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Aug 29, 2024

Spacing marks are called so, because they have a positive advance
width, unlike their non-spacing neighbors (as the name indicates).
After this we stop assigning such gc=Mc codepoints a zero width.

Closes #17810

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Product-Terminal The new Windows Terminal. labels Aug 29, 2024
@zadjii-msft zadjii-msft merged commit 0cb3426 into main Aug 29, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/lhecker/17810-spacing-marks branch August 29, 2024 20:27
DHowett pushed a commit that referenced this pull request Sep 4, 2024
Spacing marks are called so, because they have a positive advance
width, unlike their non-spacing neighbors (as the name indicates).
After this we stop assigning such gc=Mc codepoints a zero width.

Closes #17810

(cherry picked from commit 0cb3426)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgSg1L4
Service-Version: 1.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
Development

Successfully merging this pull request may close these issues.

Canary: rendering issue
3 participants