Prevent a crash when holding enter when creating a tab #17788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area-TerminalControl
DHowett
approved these changes
Aug 23, 2024
lhecker
approved these changes
Aug 23, 2024
carlos-zamora
deleted the
dev/migrie/b/17776-dont-crash-on-automark-before-create
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess I didn't realize that
SendCharEventcould get called beforeCreate. In that scenario,enterwould hit the automark codepath (due to #17761), then crash because there was no text buffer.Pretty easy to prevent.
Closes #17776