Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Holding Enter while opening a new tab crashes Terminal #17776

Closed
DHowett opened this issue Aug 22, 2024 · 0 comments · Fixed by #17788
Closed

Holding Enter while opening a new tab crashes Terminal #17776

DHowett opened this issue Aug 22, 2024 · 0 comments · Fixed by #17788
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.

Comments

@DHowett
Copy link
Member

DHowett commented Aug 22, 2024

This is likely due to autoMarkPrompts - it tries to set a mark, but it must measure the text buffer, but there is no text buffer. Or there is one but it gets deleted while resizing.
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 22, 2024
@DHowett DHowett added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) labels Aug 22, 2024
zadjii-msft added a commit that referenced this issue Aug 23, 2024
@zadjii-msft
Prevent a crash when holding enter when creating a tab
ad25998 
I guess I didn't realize that `SendCharEvent` could get called before `Create`.
In that scenario, `enter` would hit the automark codepath (due to #17761), then
crash because there was no text buffer.

Pretty easy to prevent.

Closes #17776
@zadjii-msft zadjii-msft mentioned this issue Aug 23, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) In-PR This issue has a related PR Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent a crash when holding enter when creating a tab microsoft/terminal
1 participant
@DHowett