Clip the "current commandline" at the cursor position #17781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly relevant to pwsh with the "ghost text" enabled. In that scenario, pwsh writes out the predicted command to the right of the cursor. With `showSuggestions(useCommandline=true)`, we'd auto-include that text in the filter, and that was effectively useless. This instead defaults us to not use anything to the right of the cursor (inclusive) for what we consider "the current commandline" closes #17772
carlos-zamora
approved these changes
Aug 22, 2024
|
We have a test that explicitly checks for this. We will need to remove it. |
lhecker
approved these changes
Aug 22, 2024
| // (also account for the fact that the cursor may be in the middle of a commandline) | ||
| if (!commands.empty() && | ||
| !trimmedCurrentCommand.empty() && | ||
| std::wstring{ commands.back() }.substr(0, trimmedCurrentCommand.size()) == trimmedCurrentCommand) |
There was a problem hiding this comment.
Use wstring_view here. The commands vector isn't being deleted during this line after all.
|
Something is suspiciously polluting the test state here: |
carlos-zamora
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is particularly relevant to pwsh with the "ghost text" enabled. In that scenario, pwsh writes out the predicted command to the right of the cursor. With
showSuggestions(useCommandline=true), we'd auto-include that text in the filter, and that was effectively useless.This instead defaults us to not use anything to the right of the cursor (inclusive) for what we consider "the current commandline"
closes #17772