Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when useCommandline, trim the CurrentCommand at the cursor pos (to prevent pwsh ghost text from populating menu) #17772

Closed
Tracked by #15845
zadjii-msft opened this issue Aug 22, 2024 · 1 comment · Fixed by #17781
Closed
Tracked by #15845

when useCommandline, trim the CurrentCommand at the cursor pos (to prevent pwsh ghost text from populating menu) #17772

zadjii-msft opened this issue Aug 22, 2024 · 1 comment · Fixed by #17781
Labels
In-PR This issue has a related PR Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Aug 22, 2024 •
edited
Loading

title
@zadjii-msft zadjii-msft mentioned this issue Aug 22, 2024
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 22, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service

This comment was marked as off-topic.

Sign in to view
@zadjii-msft zadjii-msft reopened this Aug 22, 2024
zadjii-msft added a commit that referenced this issue Aug 22, 2024
@zadjii-msft
Clip the "current commandline" at the cursor position
57eb45f 
This is particularly relevant to pwsh with the "ghost text" enabled. In that
scenario, pwsh writes out the predicted command to the right of the cursor. With
`showSuggestions(useCommandline=true)`, we'd auto-include that text in the
filter, and that was effectively useless.

This instead defaults us to not use anything to the right of the cursor
(inclusive) for what we consider "the current commandline"

closes #17772
@zadjii-msft zadjii-msft mentioned this issue Aug 22, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 22, 2024
DHowett pushed a commit that referenced this issue Aug 23, 2024
@zadjii-msft
Clip the "current commandline" at the cursor position (#17781)
cd8c125 
This is particularly relevant to pwsh with the "ghost text" enabled. In
that scenario, pwsh writes out the predicted command to the right of the
cursor. With `showSuggestions(useCommandline=true)`, we'd auto-include
that text in the filter, and that was effectively useless.

This instead defaults us to not use anything to the right of the cursor
(inclusive) for what we consider "the current commandline"

closes #17772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
In-PR This issue has a related PR Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clip the "current commandline" at the cursor position microsoft/terminal
1 participant
@zadjii-msft