Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[schema] Update allowed types for startingDirectory #14408

Merged
merged 1 commit into from
Nov 21, 2022
Merged

[schema] Update allowed types for startingDirectory #14408

merged 1 commit into from
Nov 21, 2022

Conversation

BenConstable9
Copy link
Contributor

@BenConstable9 BenConstable9 commented Nov 18, 2022 •
edited by carlos-zamora
Loading

Update the schema to support null.

PR Checklist

@ghost ghost added Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. labels Nov 18, 2022
zadjii-msft
zadjii-msft approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

carlos-zamora
carlos-zamora approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@carlos-zamora carlos-zamora changed the title Update allowed types for startingDirectory [schema] Update allowed types for startingDirectory Nov 21, 2022
@carlos-zamora carlos-zamora merged commit feed768 into microsoft:main Nov 21, 2022
DHowett pushed a commit that referenced this pull request Dec 12, 2022
@BenConstable9 @DHowett
[schema] Update allowed types for startingDirectory (#14408)
4938b92 
Update the schema to support null.

## PR Checklist
* [x] Closes #14299
* [x] Schema updated.

(cherry picked from commit feed768)
Service-Card-Id: 87207135
Service-Version: 1.16
DHowett pushed a commit that referenced this pull request Dec 12, 2022
@BenConstable9 @DHowett
[schema] Update allowed types for startingDirectory (#14408)
28e6265 
Update the schema to support null.

## PR Checklist
* [x] Closes #14299
* [x] Schema updated.

(cherry picked from commit feed768)
Service-Card-Id: 87207134
Service-Version: 1.15
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal v1.15.3465.0 and v1.15.3466.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 14, 2022
Closed
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect type in settings schema for startingDirectory property
4 participants
@BenConstable9 @lhecker @carlos-zamora @zadjii-msft