Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect type in settings schema for startingDirectory property #14299

Closed
PetSerAl opened this issue Oct 28, 2022 · 4 comments · Fixed by #14408
Closed

Incorrect type in settings schema for startingDirectory property #14299

PetSerAl opened this issue Oct 28, 2022 · 4 comments · Fixed by #14408
Labels
Area-Schema Things that have to do with the json schema. good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.17

Comments

@PetSerAl
Copy link

In settings schema (https://aka.ms/terminal-profiles-schema) type of startingDirectory property described as string. But when you set inherit starting directory from parent process, the null value get saved to the property.
@PetSerAl PetSerAl added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Oct 28, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 28, 2022
@zadjii-msft
Copy link
Member

Huh. Didn't know that null wasn't a valid value for a string in json schema. See: https://stackoverflow.com/questions/16241333/specify-a-value-can-be-a-string-or-null-with-json-schema

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-Schema Things that have to do with the json schema. good first issue This is a fix that might be easier for someone to do as a first contribution and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 28, 2022
@carlos-zamora carlos-zamora added the Product-Terminal The new Windows Terminal. label Oct 28, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 28, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.17 milestone Oct 28, 2022
@BenConstable9
Copy link
Contributor

Happy to submit a PR for this simple fix.

@BenConstable9 BenConstable9 mentioned this issue Nov 18, 2022
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Nov 18, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Needs-Tag-Fix Doesn't match tag requirements and removed In-PR This issue has a related PR labels Nov 21, 2022
carlos-zamora pushed a commit that referenced this issue Nov 21, 2022
@BenConstable9
[schema] Update allowed types for startingDirectory (#14408)
feed768 
Update the schema to support null.

## PR Checklist
* [x] Closes #14299
* [x] Schema updated.
DHowett pushed a commit that referenced this issue Dec 12, 2022
@BenConstable9 @DHowett
[schema] Update allowed types for startingDirectory (#14408)
4938b92 
Update the schema to support null.

## PR Checklist
* [x] Closes #14299
* [x] Schema updated.

(cherry picked from commit feed768)
Service-Card-Id: 87207135
Service-Version: 1.16
DHowett pushed a commit that referenced this issue Dec 12, 2022
@BenConstable9 @DHowett
[schema] Update allowed types for startingDirectory (#14408)
28e6265 
Update the schema to support null.

## PR Checklist
* [x] Closes #14299
* [x] Schema updated.

(cherry picked from commit feed768)
Service-Card-Id: 87207134
Service-Version: 1.15
@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14408, which has now been successfully released as Windows Terminal v1.15.3465.0 and v1.15.3466.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Dec 14, 2022

🎉This issue was addressed in #14408, which has now been successfully released as Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Schema Things that have to do with the json schema. good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.17
Development

Successfully merging a pull request may close this issue.

[schema] Update allowed types for startingDirectory BenConstable9/terminal
4 participants
@carlos-zamora @BenConstable9 @PetSerAl @zadjii-msft