Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable autocorrect for command, path and find text inputs #11137

Merged
merged 2 commits into from
Sep 7, 2021
Merged

Disable autocorrect for command, path and find text inputs #11137

merged 2 commits into from
Sep 7, 2021

Conversation

ianjoneill
Copy link
Contributor

@ianjoneill ianjoneill commented Sep 3, 2021 •
edited
Loading

Summary of the Pull Request

Disables autocorrect for command, path and find text inputs. Does not disable it for profile names, tab titles or colour scheme names.

PR Checklist

  • Closes Text input fields in Settings have autocorrect enabled (oops) #11133
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Validation Steps Performed

Manually typed bash -i -l into the profile command text input and found it no longer auto-capitalised the I.

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Sep 3, 2021
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Sep 7, 2021
@carlos-zamora
Copy link
Member

carlos-zamora commented Sep 7, 2021 •
edited
Loading

@msftbot merge this in 5 minutes

EDIT: yup... bot is still broken :(

@carlos-zamora carlos-zamora merged commit 43c76ee into microsoft:main Sep 7, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 20, 2021
Closed
@ianjoneill ianjoneill mentioned this pull request Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text input fields in Settings have autocorrect enabled (oops)
3 participants
@ianjoneill @carlos-zamora @zadjii-msft