Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text input fields in Settings have autocorrect enabled (oops) #11133

Closed
joslinpr opened this issue Sep 3, 2021 · 4 comments · Fixed by #11137
Closed

Text input fields in Settings have autocorrect enabled (oops) #11133

joslinpr opened this issue Sep 3, 2021 · 4 comments · Fixed by #11137
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@joslinpr
Copy link

joslinpr commented Sep 3, 2021

Windows Terminal version (or Windows build number)

Windows 10 ECB 9.0 SAC 20H2 / Windows Feature Experience Pack 120.2212.551.0

Other Software

OpenSSH_for_Windows_7.7p1, LibreSSL 2.6.5

Steps to reproduce

Create a New Profile / Edit an existing profile.

Under General, type into command line:

C:\Windows\System32\OpenSSH\ssh.exe -A -i C:\Users\username\.ssh\id_rsa user@hostname

What you get is:

C:\Windows\System32\OpenSSH\ssh.exe -A-I C:\Users\username\.ssh\id_rsa username@hostname

Note the capital I. This does not occur when you cut and paste, but will if you remove the "I" and type "i".

If you use the new profile, you get the unexpected error "no support for PKCS#11." from ssh.exe.

Expected Behavior

What you type is what you get.

Actual Behavior

Autocorrect changes -i to -I, leading to an error message.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 3, 2021
@DHowett
Copy link
Member

DHowett commented Sep 3, 2021

Jeez-o, we should not have autocorrect enabled on our input fields!

@DHowett DHowett changed the title Settings Tab Using Autocorrect Leads to Unexpected Behavior Text input fields in Settings have autocorrect enabled (oops) Sep 3, 2021
@DHowett DHowett added Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Sep 3, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 3, 2021
@DHowett DHowett added this to the Terminal v1.12 milestone Sep 3, 2021
@ianjoneill
Copy link
Contributor

This looks easy to fix - I assume you'd like to keep autocorrect enabled in text-boxes for names (e.g. profile name, tab title), but not for paths/command lines etc.

@ianjoneill ianjoneill mentioned this issue Sep 3, 2021
Merged
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Sep 3, 2021
@elsaco
Copy link

elsaco commented Sep 5, 2021 •
edited
Loading

Why is only "-i" being capitalized? The first option "-A" won't be autocorrected if typed "-a". None other ssh.exe options are being capitalized. This is not SSH client related.

Just by entering "-i" in the command line box it will be turned into "-I". I tried "--i" and "---i" and same behavior. However, if "I" is being corrected any other "i" entries won't be capitalized.

@ghost ghost removed the In-PR This issue has a related PR label Sep 7, 2021
carlos-zamora pushed a commit that referenced this issue Sep 7, 2021
@ianjoneill
Disable autocorrect for command, path and find text inputs (#11137)
43c76ee 
## Summary of the Pull Request
Disables autocorrect for command, path and find text inputs. Does not disable it for profile names, tab titles or colour scheme names.

## PR Checklist
* [x] Closes #11133
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Manually typed `bash -i -l` into the profile command text input and found it no longer auto-capitalised the I.
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 7, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11137, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

@DHowett DHowett mentioned this issue Mar 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Disable autocorrect for command, path and find text inputs ianjoneill/terminal
4 participants
@DHowett @elsaco @ianjoneill @joslinpr