Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md link broken #7889

Closed
jpz opened this issue Oct 12, 2020 · 1 comment · Fixed by #7926
Closed

README.md link broken #7889

jpz opened this issue Oct 12, 2020 · 1 comment · Fixed by #7926
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@jpz
Copy link

jpz commented Oct 12, 2020

The link to "Desktop Bridge VC++ v14 Redistributable Package" in README.md is unavailable.
@jpz jpz added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Oct 12, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 12, 2020
@zadjii-msft
Copy link
Member

You know what, it looks like that's actually no longer required, so let's just yank that link.

@zadjii-msft zadjii-msft mentioned this issue Oct 15, 2020
Merged
4 tasks
@ghost ghost added the In-PR This issue has a related PR label Oct 15, 2020
DHowett pushed a commit that referenced this issue Oct 15, 2020
@zadjii-msft
doc: Remove unnecessary link to VC redist, update md lint rules (#7926)
5662cc1 
Terminal ships with this dependency embedded, and it is not required that you install it separately. Since the link is broken, let's just remove it entirely.

* [x] fixes #7889 
* [x] related to #7917 (comment)
* [x] I work here
* [x] is a docs update

Additionally, update the markdown linter rules in the wake of #7637, because apparently that was never actually applied to any files, so now the onus is on the first person to touch any of our markdown files.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: Remove unnecessary link to VC redist, update md lint rules microsoft/terminal
2 participants
@jpz @zadjii-msft