Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove unnecessary link to VC redist, update md lint rules #7926

Merged
merged 5 commits into from
Oct 15, 2020

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Oct 15, 2020

Terminal ships with this dependency embedded, and it is not required that you install it separately. Since the link is broken, let's just remove it entirely.


Additionally, update the markdown linter rules in the wake of #7637, because apparently that was never actually applied to any files, so now the onus is on the first person to touch any of our markdown files.

Terminal ships with this dependency embedded, and it is not required that you install it separately.
@ghost ghost added the Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs label Oct 15, 2020
@skyline75489
Copy link
Collaborator

skyline75489 commented Oct 15, 2020

I wonder if there's anything else in the README that has decayed.

For example, suggested change:

-Kayla Cinnamon, Program Manager: @cinnamon_msft 
+Kayla Cinnamon, Program Manager: @cinnamon_msft (**Make sure you follow her ❤️** )
-Dustin Howett, Engineering Lead: @dhowett 
+Dustin Howett, Engineering Lead: @dhowett (**This guy tweets a lot**)
-Michael Niksa, Senior Developer: @michaelniksa
+Michael Niksa, Senior Developer: @michaelniksa(**He doesn't really tweet**)
-Mike Griese, Developer: @zadjii
+Mike Griese, Developer: @zadjii (**nah, no tweet. But he just became a father! 🎉 **)
-Carlos Zamora, Developer: @cazamor_msft
+Carlos Zamora, Developer: @cazamor_msft(**Our a11y hero**)
-Leon Liang, Developer: @leonmsft
+Leon Liang, Developer: @leonmsft(**hey there, how you doing**)
-Pankaj Bhojwani, Developer
+Pankaj Bhojwani, Developer(**so...you're still using facebook?**)

Now this is informative.

@zadjii-msft
Copy link
Member Author

Ah. We didn't actually update any files for the linter, we just added it. Well that's a hassle.

@zadjii-msft zadjii-msft changed the title Remove unnecessary link to VC redistributable Remove unnecessary link to VC redistributable, update markdown linter rules Oct 15, 2020
@zadjii-msft zadjii-msft added Area-Build Issues pertaining to the build system, CI, infrastructure, meta Product-Meta The product is the management of the products. labels Oct 15, 2020
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were most of these changes made before the line length was set to 400? It looks like they all got super short.

@zadjii-msft
Copy link
Member Author

Were most of these changes made before the line length was set to 400? It looks like they all got super short.

Yea, they were. I can revert those if you want.

@DHowett DHowett changed the title Remove unnecessary link to VC redistributable, update markdown linter rules doc: Remove unnecessary link to VC redist, update md lint rules Oct 15, 2020
@DHowett DHowett merged commit 5662cc1 into master Oct 15, 2020
@DHowett DHowett deleted the zadjii-msft-patch-2 branch October 15, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Meta The product is the management of the products.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md link broken
3 participants