-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Remove unnecessary link to VC redist, update md lint rules #7926
Conversation
Terminal ships with this dependency embedded, and it is not required that you install it separately.
I wonder if there's anything else in the README that has decayed. For example, suggested change: -Kayla Cinnamon, Program Manager: @cinnamon_msft
+Kayla Cinnamon, Program Manager: @cinnamon_msft (**Make sure you follow her ❤️** )
-Dustin Howett, Engineering Lead: @dhowett
+Dustin Howett, Engineering Lead: @dhowett (**This guy tweets a lot**)
-Michael Niksa, Senior Developer: @michaelniksa
+Michael Niksa, Senior Developer: @michaelniksa(**He doesn't really tweet**)
-Mike Griese, Developer: @zadjii
+Mike Griese, Developer: @zadjii (**nah, no tweet. But he just became a father! 🎉 **)
-Carlos Zamora, Developer: @cazamor_msft
+Carlos Zamora, Developer: @cazamor_msft(**Our a11y hero**)
-Leon Liang, Developer: @leonmsft
+Leon Liang, Developer: @leonmsft(**hey there, how you doing**)
-Pankaj Bhojwani, Developer
+Pankaj Bhojwani, Developer(**so...you're still using facebook?**) Now this is informative. |
Ah. We didn't actually update any files for the linter, we just added it. Well that's a hassle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were most of these changes made before the line length was set to 400? It looks like they all got super short.
Yea, they were. I can revert those if you want. |
Terminal ships with this dependency embedded, and it is not required that you install it separately. Since the link is broken, let's just remove it entirely.
Additionally, update the markdown linter rules in the wake of #7637, because apparently that was never actually applied to any files, so now the onus is on the first person to touch any of our markdown files.