Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about multiline paste to editor #7006

Closed
KalleOlaviNiemitalo opened this issue Jul 22, 2020 · 6 comments · Fixed by #9586
Closed

Don't warn about multiline paste to editor #7006

KalleOlaviNiemitalo opened this issue Jul 22, 2020 · 6 comments · Fixed by #9586
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@KalleOlaviNiemitalo
Copy link

Description of the new feature/enhancement

I want the #2349 warning when pasting multiline text to a shell, but not when pasting to an editor that won't execute the lines as commands.

Proposed technical implementation details (optional)

Potential ways to detect such an editor:

Whichever heuristic is used, there is a risk that the editor is killed and the modes are left active. Perhaps the configuration should have a separate opt-in for each heuristic.

@KalleOlaviNiemitalo KalleOlaviNiemitalo added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jul 22, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 22, 2020
@zadjii-msft
Copy link
Member

Of those three options, the bracketed paste one is my favorite. Consider something like tmux, which is going to use the alt buffer and mouse tracking, but is also likely sitting at a shell prompt.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jul 22, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jul 22, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Jul 22, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 23, 2020
@vadimkantorov
Copy link

Stumbled on this. This is annoying when copy-pasting code into vim, since there is no way to suppress the message after first appearance.

@zadjii-msft
Copy link
Member

I mean, there is these settings so there's not no way...

@vadimkantorov
Copy link

I meant no quick UI way, many apps would ask right away if one wants to suppress the message: "Do not show again" button kind of way

@UID1
Copy link

UID1 commented Oct 2, 2020

Agree on this issue. When copying and pasting into a running ipython console or a Scala REPL then this warning is merely a nuisance. Those interactive enviroments know how to handle multi-line pastes.

@ghost ghost added the In-PR This issue has a related PR label Mar 23, 2021
@ghost ghost closed this as completed in #9586 Apr 7, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 7, 2021
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9586, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants