Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paste size warnings #2349

Closed
trajano opened this issue Aug 8, 2019 · 2 comments · Fixed by #6631
Closed

Paste size warnings #2349

trajano opened this issue Aug 8, 2019 · 2 comments · Fixed by #6631
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@trajano
Copy link

trajano commented Aug 8, 2019

Description of the new feature/enhancement

When pasting a large amount of text or even just having multiple lines show a OPTIONALLY warning to the user. This is the behaviour in Cmder

Proposed technical implementation details (optional)
@trajano trajano added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 8, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 8, 2019
@zadjii-msft
Copy link
Member

Seems like a reasonable feature request, with prior art to serve as the inspiration. I'd be happy to review a PR for this :)

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Aug 8, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 8, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 8, 2019
@DHowett-MSFT DHowett-MSFT added Help Wanted We encourage anyone to jump in on these. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 9, 2019
@zadjii-msft zadjii-msft mentioned this issue Mar 16, 2020
Closed
@Z1ni Z1ni mentioned this issue May 30, 2020
Closed
@beviu beviu mentioned this issue Jun 22, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Jun 22, 2020
@ghost ghost closed this as completed in #6631 Jul 1, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jul 1, 2020
ghost pushed a commit that referenced this issue Jul 1, 2020
@beviu
Add settings to warn about large or multiline pastes (#6631)
985f85d 
Before sending calling the `HandleClipboardData` member function on
the `PasteFromClipboardEventArgs` object when we receive a request
from the `TermControl` to send it the clipboard's text content, we
now display a warning to let the user choose whether to continue or
not if the text is larger than 5 KiB or contains the _new line_
character, which can be a security issue if the user is pasting the
text in a shell.

These warnings can be disabled with the `largePasteWarning` and
`multiLinePasteWarning` global settings respectively.

Closes #2349
@ghost
Copy link

ghost commented Jul 22, 2020

🎉This issue was addressed in #6631, which has now been successfully released as Windows Terminal Preview v1.2.2022.0.:tada:

Handy links:

@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Jul 22, 2020
Closed
@KalleOlaviNiemitalo KalleOlaviNiemitalo mentioned this issue Aug 13, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Add settings to warn about large or multiline pastes
3 participants
@trajano @DHowett-MSFT @zadjii-msft