.Net: ADR for Text Search Abstractions #8307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
markwallace-microsoft
force-pushed
the
users/markwallace-text-search-adr
branch
from
a39455e
to
0bd8e70
Compare
markwallace-microsoft
force-pushed
the
users/markwallace-text-search-adr
branch
from
0bd8e70
to
6dac921
Compare
markwallace-microsoft
changed the title
westey-m
reviewed
Aug 21, 2024
westey-m
reviewed
Aug 21, 2024
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/EqualityFilterClause.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/EqualityFilterClause.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/EqualityFilterClause.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/BasicFilterOptions.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/TextSearchResult.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/TextSearchResult.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/TextSearchOptions.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/KernelSearchResults.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/KernelSearchResults.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/KernelSearchResults.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
dotnet/src/SemanticKernel.Abstractions/Search/TextSearchResult.cs
Outdated
Show resolved
Hide resolved
westey-m
reviewed
Aug 21, 2024
westey-m
reviewed
Aug 22, 2024
westey-m
reviewed
Aug 22, 2024
westey-m
approved these changes
Aug 22, 2024
4 tasks
SergeyMenshykh
approved these changes
Aug 22, 2024
dmytrostruk
reviewed
Aug 22, 2024
dotnet/src/SemanticKernel.Abstractions/Search/EqualityFilterClause.cs
Outdated
Show resolved
Hide resolved
dotnet/src/SemanticKernel.Abstractions/Search/TextSearchOptions.cs
Outdated
Show resolved
Hide resolved
dmytrostruk
approved these changes
Aug 22, 2024
markwallace-microsoft
merged commit d7287bb
into
microsoft:feature-vector-search
10 checks passed
markwallace-microsoft
added a commit
that referenced
this pull request
Aug 27, 2024
…nelFunctions (#8335) ### Motivation and Context Follow up PR to #8307 ### Description There are two main use cases we need to support: 1. Enable Prompt Engineers to easily insert grounding information in prompts i.e. support for Retrieval-Augmented Generation scenarios. 2. Enable Developers to register search plugins which can be called by the LLM to retrieve additional data it needs to respond to a user ask i.e. support for Function Calling scenarios. What both of these scenarios have in common is that we need to generate a `KernelPlugin` from a search service and register it for use with the `Kernel`. This PR includes `TextSearchExtensions` class which adds extension methods to create `KernelPlugin`s and `KernelFunction`s from an `ITextSearch` instance. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Closes #5799
Description
Contribution Checklist