Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Simplify how additional text search filter parameters are specified #8328

Open
markwallace-microsoft opened this issue Aug 22, 2024 · 0 comments · Fixed by #8426
Open
Assignees
Labels
Ignite .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) text_search

Comments

@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Aug 22, 2024

See: #8307 (comment)

Once we get to implementation, it'll be nice to have a built in variation of this whole method, that just takes a function name, description and kernel parameter metadata in addition to query count and skip.
That way, someone can just pass in the function name, description and a parameter for site, and here in the highlighted section, we can loop over the passed in parameters, and just get them one by one from arguments, and add them to the basic filter automatically.

That way, someone doesn't have to write any of this for the simple case where they just want another parameter that should be passed along as a filter option.

@markwallace-microsoft markwallace-microsoft self-assigned this Aug 22, 2024
@markwallace-microsoft markwallace-microsoft converted this from a draft issue Aug 22, 2024
@markwallace-microsoft markwallace-microsoft added triage .NET Issue or Pull requests regarding .NET code text_search and removed triage labels Aug 22, 2024
@github-actions github-actions bot changed the title Allow additional parameters to be associated with a filter to be easily specified .Net: Allow additional parameters to be associated with a filter to be easily specified Aug 22, 2024
@evchaki evchaki added the sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) label Aug 22, 2024
@markwallace-microsoft markwallace-microsoft changed the title .Net: Allow additional parameters to be associated with a filter to be easily specified .Net: Allow additional parameters to be associated with a text search filter to be easily specified Aug 27, 2024
@markwallace-microsoft markwallace-microsoft changed the title .Net: Allow additional parameters to be associated with a text search filter to be easily specified .Net: Simplify how additional text search filter parameters are specified Aug 30, 2024
markwallace-microsoft added a commit that referenced this issue Sep 2, 2024
…fied (#8426)

### Motivation and Context

Closes #8328 

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Dmytro Struk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ignite .NET Issue or Pull requests regarding .NET code sk team issue A tag to denote issues that where created by the Semantic Kernel team (i.e., not the community) text_search
Projects
Status: Sprint: Done
2 participants