Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip out @alpha items from generated reports #4329

Merged
merged 3 commits into from
Sep 29, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: Add changesets
Josmithr committed Sep 20, 2023
commit a2f5b22879dba3d13edbe57beb02408f7a6bc406
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
Josmithr marked this conversation as resolved.
Show resolved Hide resolved
{
"packageName": "@microsoft/api-documenter",
"comment": "Add notes for @alpha items when encountered. Mimics the existing behavior for @beta items.",
"type": "patch"
}
],
"packageName": "@microsoft/api-documenter"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@microsoft/api-extractor",
"comment": "Don't strip out @alpha items when generating API reports.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmichon-msft for future reference, this should have been a MINOR version bump. It is a significant behavioral change that may cause previously undisclosed content to appear on a public website.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, I've gotten so used to the Rush projects where the version bump isn't part of the PR that I forgot to check that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the process for correcting this? I'm happy to put up a PR fixing this if I can get guidance.

"type": "patch"
}
],
"packageName": "@microsoft/api-extractor"
}