Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip out @alpha items from generated reports #4329

Merged
merged 3 commits into from
Sep 29, 2023

Conversation

Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Sep 14, 2023

It is useful for @alpha items to appear in metadata and generated documentation. The system currently unconditionally strips all @alpha items out.

I don't know how important it is to preserve existing behavior. If it is, perhaps this should be configurable somehow? Any feedback / suggestions would be appreciated.

I posted a question in the chatroom about this but have not yet heard back. I'll link to this PR from there as well.

It is useful for `@alpha` items to appear in metadata and generated documentation. The system currently unconditionally strips all `@alpha` items out.

I don't know how important it is to preserve existing behavior. If so, perhaps this should be configurable somehow? Any feedback / suggestions would be appreciated.
@Josmithr Josmithr changed the title Don't strip out @alpha items from report Don't strip out @alpha items from generated reports Sep 14, 2023
@dmichon-msft
Copy link
Contributor

You'll want to do a search for ReleaseTag.Beta and validate that all the code paths that identify @beta elements have similar paths for @alpha items, e.g. marking them as preview features.

@Josmithr
Copy link
Contributor Author

You'll want to do a search for ReleaseTag.Beta and validate that all the code paths that identify @beta elements have similar paths for @alpha items, e.g. marking them as preview features.

Can do. Thanks!

@Josmithr
Copy link
Contributor Author

You'll want to do a search for ReleaseTag.Beta and validate that all the code paths that identify @beta elements have similar paths for @alpha items, e.g. marking them as preview features.

@dmichon-msft I believe I handled all of the relevant paths. I left one question about default content presentation for api-documenter, but otherwise it's hopefully ready for review.

@dmichon-msft dmichon-msft merged commit a3b9e24 into microsoft:main Sep 29, 2023
5 checks passed
@Josmithr Josmithr deleted the patch-1 branch September 29, 2023 20:57
"changes": [
{
"packageName": "@microsoft/api-extractor",
"comment": "Don't strip out @alpha items when generating API reports.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmichon-msft for future reference, this should have been a MINOR version bump. It is a significant behavioral change that may cause previously undisclosed content to appear on a public website.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah, I've gotten so used to the Rush projects where the version bump isn't part of the PR that I forgot to check that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the process for correcting this? I'm happy to put up a PR fixing this if I can get guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants