Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow RequestHeaderEncoding as a string #995

Merged
merged 1 commit into from
May 14, 2021
Merged

Flow RequestHeaderEncoding as a string #995

merged 1 commit into from
May 14, 2021

Conversation

Tratcher
Copy link
Member

Contributes to #352

We have multiple providers that use System.Text.Json to serialize the config model across processes. The Encoding type doesn't serialize, so I've changed the config model to flow the encoding by name and resolve it to an instance later.

@Tratcher Tratcher added this to the YARP 1.0.0-preview12 milestone May 13, 2021
@Tratcher Tratcher requested a review from ManickaP May 13, 2021 20:27
@Tratcher Tratcher self-assigned this May 13, 2021
Copy link
Contributor

@alnikola alnikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tratcher Tratcher merged commit b8794fc into main May 14, 2021
@Tratcher Tratcher deleted the tratcher/encoding branch May 14, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants