-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contracts should be serializable/deserializable using System.Text.Json #352
Comments
Why are you trying to serialize the configuration? If what you are trying to do is to dynamically manage the routes, then that will be handled by a new API that is being built as part of #8. |
Though serialization may come in handy even in the #8 scenario. You've got to store the data in some format. |
Having the feature you have pointed to is useful - in the meantime, we are serializing the dynamically discovered route and updating a JSON which is part of the config management system. |
@jkotalik and @davidni, you are both successfully serializing and deserializing the models using System.Text.Json as part of your providers, correct? The only values I'm aware of that wouldn't be serializable are: We should add a regression test for this scenario, and decide what to do about the two properties above. |
Other unsupported types I found in testing:
|
Describe the bug
Contracts should be serializable/deserializable using System.Text.Json
public ProxyMatch Match { get; private set; } = new ProxyMatch();
Private setters are not supported by System.Text.Json
To Reproduce
Try to read the ReverseProxy configuration with System.Text.Json - Match object is created but has null values for all properties.
Further technical details
The text was updated successfully, but these errors were encountered: