Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: operator deployment ignores custom namespace #531

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

timmhirsens
Copy link
Contributor

@timmhirsens timmhirsens commented Jul 4, 2024

Description

This fixes the operator deployment actually using the namespace defined in the helm values. Without this fix, the deployment will fail, since the configuration ConfigMap for the operator is deployed in the specified namespace while the operator itself is deployed in kube-system.

Related Issue

Fixes #492

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

@timmhirsens
Copy link
Contributor Author

@microsoft-github-policy-service agree

@timmhirsens timmhirsens marked this pull request as ready for review July 4, 2024 09:07
@timmhirsens timmhirsens requested a review from a team as a code owner July 4, 2024 09:07
Copy link
Collaborator

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@rbtr rbtr enabled auto-merge July 8, 2024 15:53
@rbtr rbtr added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@rbtr rbtr added this pull request to the merge queue Jul 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 8, 2024
@nddq nddq added this pull request to the merge queue Jul 8, 2024
Merged via the queue into microsoft:main with commit 798448c Jul 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator deployment in different namespace than kube-system.
3 participants