Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator deployment in different namespace than kube-system. #492

Closed
rbtr opened this issue Jun 19, 2024 Discussed in #487 · 0 comments · Fixed by #531
Closed

Operator deployment in different namespace than kube-system. #492

rbtr opened this issue Jun 19, 2024 Discussed in #487 · 0 comments · Fixed by #531
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority/2 P2 scope/S Change is Small type/bug Something isn't working type/enhancement New feature or request

Comments

@rbtr
Copy link
Collaborator

rbtr commented Jun 19, 2024

Discussed in #487

Originally posted by illarios June 19, 2024
As retina is able to be deployed in other namespaces and I can see that the retina-operator-config gets its namespace from the values file:

https://github.com/microsoft/retina/blob/316ad80b4829a464ed60daa50459df4ec27aab92/deploy/manifests/controller/helm/retina/templates/operator.yaml#L258C1-L263C37

I would suggest the same to happen with the operator itself, as the case now is that if you choose another namespace for deployment of retina the operator cannot start without its configuration which apparently exists in the different namespace specified in the values file.

You can see here that the operator's deployment namespace is not configurable:

retina/deploy/manifests/controller/helm/retina/templates/operator.yaml

Line 6 in 316ad80

namespace: kube-system

IMO this is actually a bug - some of the resources in the Helm chart respect the namespace set in the Values, but some have it hardcoded to kube-system, breaking the deployment.
@rbtr rbtr added type/bug Something isn't working type/enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority/2 P2 scope/S Change is Small labels Jun 19, 2024
@timmhirsens timmhirsens mentioned this issue Jul 4, 2024
Merged
7 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 8, 2024
@timmhirsens
fix: operator deployment ignores custom namespace (#531)
798448c 
# Description

This fixes the operator deployment actually using the namespace defined
in the helm values. Without this fix, the deployment will fail, since
the configuration ConfigMap for the operator is deployed in the
specified namespace while the operator itself is deployed in
`kube-system`.

## Related Issue

Fixes #492 

## Checklist

- [x] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [x] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [x] I have correctly attributed the author(s) of the code.
- [x] I have tested the changes locally.
- [x] I have followed the project's style guidelines.
- [x] I have updated the documentation, if necessary.
- [x] I have added tests, if applicable.
@nddq nddq closed this as completed in #531 Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed priority/2 P2 scope/S Change is Small type/bug Something isn't working type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: operator deployment ignores custom namespace timmhirsens/retina
1 participant
@rbtr