Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signing images based on matrix and only run release charts on tags #524

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Jul 1, 2024

Description

As title. Closed #513

Related Issue

If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.

Checklist

  • I have read the contributing documentation.
  • I signed and signed-off the commits (git commit -S -s ...). See this documentation on signing commits.
  • I have correctly attributed the author(s) of the code.
  • I have tested the changes locally.
  • I have followed the project's style guidelines.
  • I have updated the documentation, if necessary.
  • I have added tests, if applicable.

Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes made.

Additional Notes

Add any additional notes or context about the pull request here.


Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.

@nddq nddq added type/fix Fixes something priority/0 P0 labels Jul 1, 2024
@nddq nddq self-assigned this Jul 1, 2024
@nddq nddq requested a review from a team as a code owner July 1, 2024 18:50
@nddq nddq requested review from matmerr and alam-tahmid July 1, 2024 18:50
@nddq nddq added this pull request to the merge queue Jul 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2024
@nddq nddq added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 07550e7 Jul 1, 2024
22 checks passed
@nddq nddq deleted the fix/imageSigning branch July 1, 2024 23:12
matmerr pushed a commit to matmerr/retina that referenced this pull request Jul 3, 2024
…gs (microsoft#524)

# Description

As title. Closed microsoft#513
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/0 P0 type/fix Fixes something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pipeline] Build Agent Windows image is failing on main
2 participants