Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipeline] Build Agent Windows image is failing on main #513

Closed
anubhabMajumdar opened this issue Jun 28, 2024 · 0 comments · Fixed by #514 or #524
Closed

[pipeline] Build Agent Windows image is failing on main #513

anubhabMajumdar opened this issue Jun 28, 2024 · 0 comments · Fixed by #514 or #524
Assignees
Labels
area/windows help wanted Extra attention is needed priority/0 P0 type/bug Something isn't working type/fix Fixes something

Comments

@anubhabMajumdar
Copy link
Contributor

anubhabMajumdar commented Jun 28, 2024

Describe the bug
The Build Agent Windows Images GH action is failing, at least since this commit .

Ref: https://github.com/microsoft/retina/actions/runs/9715944951/job/26818480367

image

To Reproduce
Check pipeline runs post commits on main.

Expected behavior
All pipelines should pass.

@anubhabMajumdar anubhabMajumdar added type/bug Something isn't working help wanted Extra attention is needed type/fix Fixes something area/windows priority/0 P0 labels Jun 28, 2024
@nddq nddq self-assigned this Jun 28, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
# Description
As title. Closes #513 
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
@nddq nddq closed this as completed in #514 Jul 1, 2024
@nddq nddq reopened this Jul 1, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 1, 2024
…gs (#524)

# Description

As title. Closed #513
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
@nddq nddq closed this as completed in #524 Jul 1, 2024
matmerr pushed a commit to matmerr/retina that referenced this issue Jul 3, 2024
# Description
As title. Closes microsoft#513 
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
matmerr pushed a commit to matmerr/retina that referenced this issue Jul 3, 2024
…gs (microsoft#524)

# Description

As title. Closed microsoft#513
## Related Issue

If this pull request is related to any issue, please mention it here.
Additionally, make sure that the issue is assigned to you before
submitting this pull request.

## Checklist

- [ ] I have read the [contributing
documentation](https://retina.sh/docs/contributing).
- [ ] I signed and signed-off the commits (`git commit -S -s ...`). See
[this
documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification)
on signing commits.
- [ ] I have correctly attributed the author(s) of the code.
- [ ] I have tested the changes locally.
- [ ] I have followed the project's style guidelines.
- [ ] I have updated the documentation, if necessary.
- [ ] I have added tests, if applicable.

## Screenshots (if applicable) or Testing Completed

Please add any relevant screenshots or GIFs to showcase the changes
made.

## Additional Notes

Add any additional notes or context about the pull request here.

---

Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more
information on how to contribute to this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/windows help wanted Extra attention is needed priority/0 P0 type/bug Something isn't working type/fix Fixes something
Projects
None yet
2 participants