-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: embed version in kubectl-retina with goreleaser #170
Conversation
9902835
to
027d383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also use the kubectl-retina
to start a capture job and make sure the agent image is correct?
Signed-off-by: Evan Baker <[email protected]>
@anubhabMajumdar I tagged v0.0.3 locally and created a capture. The version is correctly interpolated in for the Pod (but it obviously doesn't exist):
|
027d383
to
836040d
Compare
# Description The ldflag needs to be the full module-aware path to the variable Version. This causes issues with kubectl-retina because that Version is used to set image versions for the k8s objects created to take captures. ## Related Issue If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request. ## Checklist - [ ] I have read the [contributing documantation](https://retina.sh/docs/contributing). - [ ] I signed and signed-off the commits (`git commit -S -s ...`) - [ ] I have correctly attributed the author(s) of the code. - [ ] I have tested the changes locally. - [ ] I have followed the project's style guidelines. - [ ] I have updated the documentation, if necessary. - [ ] I have added tests, if applicable. ## Testing ```bash $ goreleaser build --clean --snapshot --single-target ... • building binaries • partial build match=target=linux_amd64 • building binary=dist/retina_linux_amd64_v1/kubectl-retina-linux-amd64 ... ``` ```bash $ ./dist/retina_linux_amd64_v1/kubectl-retina-linux-amd64 version 0.0.2-SNAPSHOT-027d383 ``` ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. Signed-off-by: Evan Baker <[email protected]>
Description
The ldflag needs to be the full module-aware path to the variable Version. This causes issues with kubectl-retina because that Version is used to set image versions for the k8s objects created to take captures.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...
)Testing
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.