Fixed templates so C++ apps can consume C# native modules #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickGerleman
approved these changes
Aug 26, 2020
|
thanks @jonthysell . It looks like we are relying on the dotnet native packages from the SDK instead of nuget, so we just need to make sure that as VS updates itself, that we also keep this updated. |
asklar
approved these changes
Aug 27, 2020
jonthysell
force-pushed
the
csharpmodulefix
branch
from
638fa37
to
35f3fb5
Compare
jonthysell
changed the title
ghost
added
the
|
This one was marked as blocking 0.63 from being released, so I'm going to mark as approved to go into 0.63. @kmelmon @acoates-ms @asklar let me know if you have any thoughts. |
NickGerleman
added
Backport to 0.63 Approved
and removed
Request Backport to 0.63
labels
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Aug 27, 2020
…5851) Right now C++/WinRT apps have a hard time consuming C# WinRT libraries from source. We fixed this in our SampleAppCpp in order to load SampleLibraryCS, but those fixes were not put into the template for the benefit of all apps. This PR moves the fix into new `CppAppConsumeCSharpModule.(props|targets)` files. Since the fix involves importing a ton of other props/targets, and we don't want to risk breaking existing C++ apps who have no need of consuming C#-based native modules, the changes are behind a new property `ConsumeCSharpModules`. So if you have a C++/WinRT RNW app (the default) and need to consume C# native module, you can set `<ConsumeCSharpModules>true</ConsumeCSharpModules>` in your app project. This PR also fixes up the template solution files to include the projects they were missing. Closes microsoft#5825 Closes microsoft#4557
jonthysell
added a commit
that referenced
this pull request
Aug 27, 2020
) This change backports #5851 to 0.63 Original PR: Right now C++/WinRT apps have a hard time consuming C# WinRT libraries from source. We fixed this in our SampleAppCpp in order to load SampleLibraryCS, but those fixes were not put into the template for the benefit of all apps. This PR moves the fix into new `CppAppConsumeCSharpModule.(props|targets)` files. Since the fix involves importing a ton of other props/targets, and we don't want to risk breaking existing C++ apps who have no need of consuming C#-based native modules, the changes are behind a new property `ConsumeCSharpModules`. So if you have a C++/WinRT RNW app (the default) and need to consume C# native module, you can set `<ConsumeCSharpModules>true</ConsumeCSharpModules>` in your app project. This PR also fixes up the template solution files to include the projects they were missing. Closes #5825 Closes #4557
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Oct 12, 2020
This was referenced Oct 12, 2020
ghost
pushed a commit
that referenced
this pull request
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now C++/WinRT apps have a hard time consuming C# WinRT libraries from source. We fixed this in our SampleAppCpp in order to load SampleLibraryCS, but those fixes were not put into the template for the benefit of all apps.
This PR moves the fix into new
CppAppConsumeCSharpModule.(props|targets)files. Since the fix involves importing a ton of other props/targets, and we don't want to risk breaking existing C++ apps who have no need of consuming C#-based native modules, the changes are behind a new propertyConsumeCSharpModules.So if you have a C++/WinRT RNW app (the default) and need to consume C# native module, you can set
<ConsumeCSharpModules>true</ConsumeCSharpModules>in your app project.This PR also fixes up the template solution files to include the projects they were missing.
Closes #5825
Closes #4557
Microsoft Reviewers: Open in CodeFlow