-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify support for .Net Native in C++ projects #4557
Comments
ghost
added
the
Needs: Triage 🔍
New issue that needs to be reviewed by the issue management team (label applied by bot)
label
Apr 10, 2020
chrisglein
removed
the
Needs: Triage 🔍
New issue that needs to be reviewed by the issue management team (label applied by bot)
label
Apr 10, 2020
jonthysell
added a commit
that referenced
this issue
Aug 27, 2020
Right now C++/WinRT apps have a hard time consuming C# WinRT libraries from source. We fixed this in our SampleAppCpp in order to load SampleLibraryCS, but those fixes were not put into the template for the benefit of all apps. This PR moves the fix into new `CppAppConsumeCSharpModule.(props|targets)` files. Since the fix involves importing a ton of other props/targets, and we don't want to risk breaking existing C++ apps who have no need of consuming C#-based native modules, the changes are behind a new property `ConsumeCSharpModules`. So if you have a C++/WinRT RNW app (the default) and need to consume C# native module, you can set `<ConsumeCSharpModules>true</ConsumeCSharpModules>` in your app project. This PR also fixes up the template solution files to include the projects they were missing. Closes #5825 Closes #4557
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this issue
Aug 27, 2020
…5851) Right now C++/WinRT apps have a hard time consuming C# WinRT libraries from source. We fixed this in our SampleAppCpp in order to load SampleLibraryCS, but those fixes were not put into the template for the benefit of all apps. This PR moves the fix into new `CppAppConsumeCSharpModule.(props|targets)` files. Since the fix involves importing a ton of other props/targets, and we don't want to risk breaking existing C++ apps who have no need of consuming C#-based native modules, the changes are behind a new property `ConsumeCSharpModules`. So if you have a C++/WinRT RNW app (the default) and need to consume C# native module, you can set `<ConsumeCSharpModules>true</ConsumeCSharpModules>` in your app project. This PR also fixes up the template solution files to include the projects they were missing. Closes microsoft#5825 Closes microsoft#4557
jonthysell
added a commit
that referenced
this issue
Aug 27, 2020
) This change backports #5851 to 0.63 Original PR: Right now C++/WinRT apps have a hard time consuming C# WinRT libraries from source. We fixed this in our SampleAppCpp in order to load SampleLibraryCS, but those fixes were not put into the template for the benefit of all apps. This PR moves the fix into new `CppAppConsumeCSharpModule.(props|targets)` files. Since the fix involves importing a ton of other props/targets, and we don't want to risk breaking existing C++ apps who have no need of consuming C#-based native modules, the changes are behind a new property `ConsumeCSharpModules`. So if you have a C++/WinRT RNW app (the default) and need to consume C# native module, you can set `<ConsumeCSharpModules>true</ConsumeCSharpModules>` in your app project. This PR also fixes up the template solution files to include the projects they were missing. Closes #5825 Closes #4557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our current SampleAppCpp has quite a few lines of code to support .Net Native based C# component assemblies. We must simplify the code:
The text was updated successfully, but these errors were encountered: