Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix codegen-windows being run from the wrong directory #13344

Closed
wants to merge 1 commit into from

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jun 13, 2024

Description

Fix codegen-windows being run from the wrong directory.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Why

codegen-windows is currently sensitive to hoisting and might be run from the wrong directory:

 × Build failed with message 6:10>EXEC : error : unknown command 'codegen-windows' [D:\~\node_module
s\@react-native-webapis\web-storage\windows\ReactNativeWebStorage.vcxproj]. Check your build configuration.

What

We should start searching for package.json from $(SolutionDir) instead of $(ProjectDir).

Screenshots

n/a

Testing

Verified locally.

Changelog

Should this change be included in the release notes: yes

Fix codegen-windows being run from the wrong directory.

Microsoft Reviewers: Open in CodeFlow

@tido64 tido64 requested a review from acoates-ms June 13, 2024 12:49
@tido64 tido64 requested a review from a team as a code owner June 13, 2024 12:49
@tido64
Copy link
Member Author

tido64 commented Jun 13, 2024

We need to backport this to 0.74-stable

@tido64 tido64 force-pushed the tido/fix-codegen-windows branch from 453d591 to 08fe1e8 Compare June 17, 2024 11:22
@tido64 tido64 marked this pull request as draft June 19, 2024 16:58
@tido64
Copy link
Member Author

tido64 commented Jun 20, 2024

Sorry for the noise.

Two issues led to this error:

  1. @react-native-webapis/web-storage was missing react-native-windows under peerDependencies
  2. @react-native-community/cli config doesn't read peerDependencies, but does read devDependencies

@tido64 tido64 closed this Jun 20, 2024
@tido64 tido64 deleted the tido/fix-codegen-windows branch June 20, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant