-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows): CompositionRootView
was renamed to ReactNativeIsland
#2067
Conversation
What is your support matrix for the fabric version of this code? For 0.74 specifically we are back pointing large chunks of our fabric work. The APIs are all marked experimental, and so are not guaranteed to be stable. In particular microsoft/react-native-windows#13319 will apply this rename to 0.74 too. Do you want to do a patch version check to have the code work on older 0.74 versions, or just update the code for 0.74 too? The APIs to size the Island also changed a little while back, so I dont think this will compile? |
Since this is experimental, I don't think we want to support more than the very latest. Since you've backported it, I'll just use the new name directly.
I can't even get latest nightly to build atm so I will have to wait till a new 0.74 is published to verify. |
14d4633
to
9f86365
Compare
9f86365
to
dea9285
Compare
Apart from microsoft/react-native-windows#13344 and #2085, I'm hitting these build errors and I have no idea why:
And if I build from Visual Studio:
It builds successfully, I think. It's just the packaging that fails. |
dea9285
to
6b9a5fe
Compare
Merging this for now since the packaging issue seems unrelated. |
Description
CompositionRootView
was renamed toReactNativeIsland
in microsoft/react-native-windows@af10f99Platforms affected
Test plan
yarn clean npm run set-react-version canary-windows yarn cd example yarn install-windows-test-app --use-fabric yarn windows