-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): allow for disabling bridgeless #2052
Conversation
@tido64 since example is on 0.73 it's hard to observe the effects of this PR, how would you like to test this? |
|
You might have to adjust
It's currently hard-coded 😛 |
surprisingly, there was no need for adjusting that 🎉 FYI, |
Awesome! I also ran it locally. I'll approve + merge whenever this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Dunno how we missed it 😅
You're welcome! Thanks for handling this so quickly! 🚀 |
Description
This PR fixes disabling bridgeless on RN
>= 0.74
where it is enabled by default (and therefore needs to be explicitly disabled now). Found during integration ofreact-native-test-app
into@callstack/repack
: callstack/repack#629Platforms affected
Test plan
yarn test:matrix 0.74
passes