Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): allow for disabling bridgeless #2052

Merged
merged 1 commit into from
May 27, 2024

Conversation

jbroma
Copy link
Contributor

@jbroma jbroma commented May 27, 2024

Description

This PR fixes disabling bridgeless on RN >= 0.74 where it is enabled by default (and therefore needs to be explicitly disabled now). Found during integration of react-native-test-app into @callstack/repack: callstack/repack#629

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

  • - verified bridgeless can be disabled on android on 0.74
  • - yarn test:matrix 0.74 passes

@jbroma
Copy link
Contributor Author

jbroma commented May 27, 2024

@tido64 since example is on 0.73 it's hard to observe the effects of this PR, how would you like to test this?

@tido64
Copy link
Member

tido64 commented May 27, 2024

@tido64 since example is on 0.73 it's hard to observe the effects of this PR, how would you like to test this?

npm run test:matrix will run e2e tests for the current version. This will include all combinations. Run npm run test:matrix 0.74 for 0.74, etc.

@tido64
Copy link
Member

tido64 commented May 27, 2024

You might have to adjust wdio.config.js to pick the emulator have you have installed:

"appium:platformVersion": "13.0",

It's currently hard-coded 😛

@tido64
Copy link
Member

tido64 commented May 27, 2024

FWIW, the fix looks like it works fine:

Screenshot_1716814491

@jbroma
Copy link
Contributor Author

jbroma commented May 27, 2024

You might have to adjust wdio.config.js to pick the emulator have you have installed:

"appium:platformVersion": "13.0",

It's currently hard-coded 😛

surprisingly, there was no need for adjusting that 🎉

FYI, yarn test:matrix 0.74 passes without any issues

@tido64
Copy link
Member

tido64 commented May 27, 2024

FYI, yarn test:matrix 0.74 passes without any issues

Awesome! I also ran it locally. I'll approve + merge whenever this is ready for review.

@jbroma jbroma marked this pull request as ready for review May 27, 2024 13:00
@jbroma jbroma requested review from kelset and tido64 as code owners May 27, 2024 13:00
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Dunno how we missed it 😅

@tido64 tido64 merged commit d2bf83b into microsoft:trunk May 27, 2024
30 checks passed
@jbroma
Copy link
Contributor Author

jbroma commented May 27, 2024

You're welcome! Thanks for handling this so quickly! 🚀

@tido64
Copy link
Member

tido64 commented May 27, 2024

FYI: https://github.com/microsoft/react-native-test-app/releases/tag/3.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants