chore: migrate TesterApp to react-native-test-app

[szymonrybczak]

TODO:

• Make sure that Release mode works
• Specify rest options through app.json e.g. New Architecture, build modes, schemas.

Summary

In this Pull Request I've migrated TesterApp to react-native-test-app.

Test plan

App should work in the same way as before.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
repack-website	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 11, 2024 2:48pm

[changeset-bot]

⚠️ No Changeset found

Latest commit: 400213d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[thymikee]

AFAIK jetifier is no longer necessary for RN libraries as all moved on to AndroidX, isn't it?

[jbroma]

this is inside of TesterApp, if we can disable jetifier then lets do it 🚀

[szymonrybczak]

if all libs are migrated what's blocking us from removing it from the template? :) probably backward compatability, i have no idea how long we should keep it 🤔

https://github.com/react-native-community/template/blob/cd5e21b702ef5c08c74796d19dd72bdb05775d17/template/android/gradle.properties#L24-L25

[thymikee]

For reference: react-native-community/cli#1662

[jbroma]

this is inside of TesterApp, if we can disable jetifier then lets do it 🚀

[jbroma]

Needed to add a bootstrap HOC as a workaround for development - apparently anything done before registering the main component causes native modules initialization to fail for some reason?

[tido64]

Needed to add a bootstrap HOC as a workaround for development - apparently anything done before registering the main component causes native modules initialization to fail for some reason?

@jbroma: Do you have repro steps? I reverted badea9d but it seems to work fine?

Android	iOS

[jbroma]

@tido64 hey, thanks for looking into this 🙏

did you restart the dev server after reverting the latest commit? This issue seems to only happen on the first load when the dev server needs to bundle everything from scratch. Here's some screenshots from the app without the latest commit:

During bundling	Finished bundling

[jbroma]

@tido64 I've narrowed it down to a more specific scenario, here are steps to repro:

cd packages/TesterApp
# start a fresh instance of dev-server
pnpm start
# in a different pane/window
pnpm android

First load of the newly installed app should cause the issue as shown above upon finish bundling (the one with AsyncStorage being null)

I've also confirmed that iOS is unaffected, this is only on Android

[jbroma]

Both release modes are working now:

• for iOS we first need to run pnpm bundle:ios and then do bundle exec pod install (inside ios dir) so that the release bundles get copied to the app properly. Important thing to note here is that after running pod install, the target is set to Debug, so it might needed to be changes to Release manually.
• for Android: for assets to be properly picked up it's best that we clean first (or rebuild) and then run the app in release mode

The commands are quite long in package.json, we might want to pull some of that stuff out into separate files in scripts dir. Ideally all issues above could be included in release scripts so that we don't need to remember about that stuff.

cc @szymonrybczak

[szymonrybczak]

Added script:
→ pnpm run ios:release - should bundle and app in Release mode
→ pnpm run android:release - should bundle and app with ./assembleRelease

[jbroma]

GJ! small nits, except for that I think we finally got this ready to be merged 💪

[jbroma]

LGTM 🎉